Skip to content

Commit 8d63600

Browse files
authored
Merge branch 'develop' into MQE-1456-amOnPage-Always-Waits
2 parents 97bc416 + 24ac1d9 commit 8d63600

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public function amOnPage($page)
3434

3535
/**
3636
* Wait for a PWA Element to NOT be visible using JavaScript.
37+
* Add the WAIT_TIMEOUT variable to your .env file for this action.
3738
*
3839
* @param null $selector
3940
* @param null $timeout
@@ -42,8 +43,6 @@ public function amOnPage($page)
4243
*/
4344
public function waitForPwaElementNotVisible($selector, $timeout = null)
4445
{
45-
$timeout = $timeout ?? $this->_getConfig()['pageload_timeout'];
46-
4746
// Determine what type of Selector is used.
4847
// Then use the correct JavaScript to locate the Element.
4948
if (\Codeception\Util\Locator::isXPath($selector)) {
@@ -55,6 +54,7 @@ public function waitForPwaElementNotVisible($selector, $timeout = null)
5554

5655
/**
5756
* Wait for a PWA Element to be visible using JavaScript.
57+
* Add the WAIT_TIMEOUT variable to your .env file for this action.
5858
*
5959
* @param null $selector
6060
* @param null $timeout
@@ -63,8 +63,6 @@ public function waitForPwaElementNotVisible($selector, $timeout = null)
6363
*/
6464
public function waitForPwaElementVisible($selector, $timeout = null)
6565
{
66-
$timeout = $timeout ?? $this->_getConfig()['pageload_timeout'];
67-
6866
// Determine what type of Selector is used.
6967
// Then use the correct JavaScript to locate the Element.
7068
if (\Codeception\Util\Locator::isXPath($selector)) {

0 commit comments

Comments
 (0)