Skip to content

MQE-1456: The "amOnPage" action always waits the entire timeout value before proceeding to the next action. #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2019
Merged

MQE-1456: The "amOnPage" action always waits the entire timeout value before proceeding to the next action. #330

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e0238a
magento-pangolin/magento2-functional-testing-framework#MQE-1456: The …
ivy00johns Apr 11, 2019
37406e7
Merge branch 'develop' into MQE-1456-amOnPage-Always-Waits
ivy00johns Apr 15, 2019
97bc416
Merge branch 'develop' into MQE-1456-amOnPage-Always-Waits
ivy00johns Apr 19, 2019
8d63600
Merge branch 'develop' into MQE-1456-amOnPage-Always-Waits
ivy00johns Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

namespace Magento\FunctionalTestingFramework\Module;

use Codeception\Module\WebDriver;

/**
* Class MagentoPwaActions
*
Expand All @@ -15,6 +17,21 @@
*/
class MagentoPwaWebDriver extends MagentoWebDriver
{
/**
* Go to the page.
*
* Overriding the MagentoWebDriver version because it contains 'waitForPageLoad'.
* The AJAX check in 'waitForPageLoad' does NOT work with a PWA.
*
* @param string $page
* @throws \Exception
* @return void
*/
public function amOnPage($page)
{
WebDriver::amOnPage($page);
}

/**
* Wait for a PWA Element to NOT be visible using JavaScript.
*
Expand Down