Skip to content

Conversation

@EinfachHans
Copy link
Contributor

closes #21820

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #21820

What is the new behavior?

  • --progress-transition added
  • --buffer-transition added
  • both default to old value: transform 150ms linear

Does this introduce a breaking change?

  • Yes
  • No

@github-actions github-actions bot added the package: core @ionic/core package label Nov 5, 2020
@brandyscarney brandyscarney added this to the 5.6.0 milestone Feb 16, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the PR! We appreciate the work you put into creating this. We recently added CSS Shadow Parts to ion-progress-bar via #22938 that will allow for customization of the progress bar transition, so I am going to close this PR.

The new feature should be available soon.

@liamdebeasi liamdebeasi closed this Mar 4, 2021
@EinfachHans EinfachHans deleted the issue-21820 branch March 4, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-progress-bar transition cannot be overridden

3 participants