Skip to content

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Feb 17, 2021

Features

This adds the following parts to progress bar:

Name Description
progress The progress bar that shows the current value (determinate) or slides back and forth (indeterminate).
stream The animated circles that appear while buffering, only shows when buffer is set and type is "determinate".
track The track bar is behind the progress bar, if the buffer property is set (determinate) the track will be the width of the buffer value.

Bug fixes

fixes

  • setting any of the color variables --progress-background, --background, etc. no longer override the colors set by the color property

resolves #20062 fixes #21820

Demo

Added additional examples to http://localhost:3333/src/components/progress-bar/test/standalone

I modified the progress bar so that you can set the background of the indeterminate using the track part and this also applies to the determinate track / buffer bar, which are the same color. The progress part will apply to the current value in determinate, and the moving bar for indeterminate. The stream part is only relevant for determinate when the buffer value is set.

progress-parts

@github-actions github-actions bot added the package: core @ionic/core package label Feb 17, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The progress animation seems to be broken on both iOS and MD

Screen.Recording.2021-03-03.at.2.44.51.PM.mov

@brandyscarney
Copy link
Member Author

@liamdebeasi Resolved issue with animation

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few description tweaks, but otherwise this is good to go. Nice job!

@github-actions github-actions bot added the package: vue @ionic/vue package label Mar 4, 2021
@github-actions github-actions bot removed the package: vue @ionic/vue package label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-progress-bar transition cannot be overridden feat: Add Progress bar radius property

3 participants