-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(progress): add parts for more design customization #22938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…with the same code
liamdebeasi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress animation seems to be broken on both iOS and MD
Screen.Recording.2021-03-03.at.2.44.51.PM.mov
Co-authored-by: Liam DeBeasi <[email protected]>
Co-authored-by: Liam DeBeasi <[email protected]>
Co-authored-by: Liam DeBeasi <[email protected]>
Co-authored-by: Liam DeBeasi <[email protected]>
|
@liamdebeasi Resolved issue with animation |
liamdebeasi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few description tweaks, but otherwise this is good to go. Nice job!
Co-authored-by: Liam DeBeasi <[email protected]>
Co-authored-by: Liam DeBeasi <[email protected]>
Features
This adds the following parts to progress bar:
progressstreambufferis set andtypeis"determinate".trackbufferproperty is set (determinate) the track will be the width of thebuffervalue.Bug fixes
fixes
--progress-background,--background, etc. no longer override the colors set by thecolorpropertyresolves #20062 fixes #21820
Demo
Added additional examples to http://localhost:3333/src/components/progress-bar/test/standalone
I modified the progress bar so that you can set the background of the indeterminate using the
trackpart and this also applies to the determinate track / buffer bar, which are the same color. Theprogresspart will apply to the current value in determinate, and the moving bar for indeterminate. Thestreampart is only relevant for determinate when thebuffervalue is set.