Skip to content

feat(progress-bar): add transition css variables #22432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EinfachHans wants to merge 1 commit into from
Closed

feat(progress-bar): add transition css variables #22432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,9 @@ ion-progress-bar,prop,type,"determinate" | "indeterminate",'determinate',false,f
ion-progress-bar,prop,value,number,0,false,false
ion-progress-bar,css-prop,--background
ion-progress-bar,css-prop,--buffer-background
ion-progress-bar,css-prop,--buffer-transition
ion-progress-bar,css-prop,--progress-background
ion-progress-bar,css-prop,--progress-transition

ion-radio,shadow
ion-radio,prop,color,string | undefined,undefined,false,false
Expand Down
13 changes: 12 additions & 1 deletion core/src/components/progress-bar/progress-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import "../../themes/ionic.globals";
@import "progress-bar.vars";

// Progress bar
// --------------------------------------------------
Expand All @@ -8,11 +9,15 @@
/**
* @prop --background: Same as --buffer-background when using a determinate progress bar, otherwise it styles the background of the ion-progress-bar itself.
* @prop --progress-background: Color of the progress bar
* @prop --progress-transition: Transition of the progress bar
* @prop --buffer-background: Color of the buffer bar
* @prop --buffer-transition: Transition of the buffer bar
*/
--background: #{ion-color(primary, base, 0.2)};
--progress-background: #{ion-color(primary, base)};
--progress-transition: #{$progress-bar-transition};
--buffer-background: var(--background);
--buffer-transition: #{$progress-bar-transition};
display: block;

position: relative;
Expand Down Expand Up @@ -57,8 +62,14 @@
.progress-buffer-bar {
/* stylelint-disable-next-line property-blacklist */
transform-origin: left top;
}

.progress {
transition: var(--progress-transition);
}

transition: transform 150ms linear;
.progress-buffer-bar {
transition: var(--buffer-transition);
}

// Progress and background bar
Expand Down
5 changes: 5 additions & 0 deletions core/src/components/progress-bar/progress-bar.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// Progress bar
// --------------------------------------------------

/// @prop - default transition of the progress-bar
$progress-bar-transition: transform 150ms linear !default;
2 changes: 2 additions & 0 deletions core/src/components/progress-bar/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ export default defineComponent({
| ----------------------- | ------------------------------------------------------------------------------------------------------------------------------------- |
| `--background` | Same as --buffer-background when using a determinate progress bar, otherwise it styles the background of the ion-progress-bar itself. |
| `--buffer-background` | Color of the buffer bar |
| `--buffer-transition` | Transition of the buffer bar |
| `--progress-background` | Color of the progress bar |
| `--progress-transition` | Transition of the progress bar |


----------------------------------------------
Expand Down