Fix PATH_IN_REPO on new release in mirror_community_pipeline.yaml
#8519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Jun 13, 2024
| # e.g. refs/tags/v0.28.1 -> v0.28.1 | ||
| echo "CHECKOUT_REF=${{ github.ref }}" >> $GITHUB_ENV | ||
| echo "PATH_IN_REPO=${${{ github.ref }}#refs/tags/}" >> $GITHUB_ENV | ||
| echo "PATH_IN_REPO=$(echo ${{ github.ref }} | sed 's/^refs\/tags\///')" >> $GITHUB_ENV |
Member
There was a problem hiding this comment.
Tricky one. Thanks for taking care of this.
(side note: having an automated reporting mechanism would have promptly alerted us about this; so all the reasons for me to work on it soon)
Collaborator
Author
There was a problem hiding this comment.
Definitely!
Even more subtle, the github action passed ( ✔️ ) but its behavior was wrong. When working on a reporting mechanism, it would be good to report values from PATH_IN_REPO/CHECKOUT_REF to slack as well.
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
…8519) Fix PATH_IN_REPO in mirror workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR after #8417.
When
github.refis a tag (e.g.refs/tags/v0.29.0), the logic to determinePATH_IN_REPO(e.g.v0.29.0) is incorrect. See example where files have been hosted at the root of the folder. This PR fixes this. Sorry about that, I did not realize how github action inject values in the bash command. This time I tested it properly and it should work correctly.EDIT: in parallel I also opened a PR to clean the mess in the dataset repo: https://huggingface.co/datasets/diffusers/community-pipelines-mirror/discussions/2
EDIT 2:: I also triggered a manual deployment to correctly push
v0.29.0(see CI) . Files have correctly been uploaded tov0.29.0/folder: https://huggingface.co/datasets/diffusers/community-pipelines-mirror/tree/main/v0.29.0