-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Mirror ./examples/community folder on HF
#8417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/examples/community folder on HF
/examples/community folder on HF./examples/community folder on HF
sayakpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
I have taken care of the todos (before merging one), too.
|
Thanks for the review and already handling the TODOs @sayakpaul! ❤️ |
|
No worries. Will merge once the CI is green (although it should not matter since the CI is not supposed to be triggered during PRs). From the todos after merging:
What exactly needs to be done here? |
I actually just pushed a new commit (72783bb) that will allow us to trigger this workflow manually. What we need to do is trigger a deploy for every existing tag + for the main branch to populate the dataset repo. The CI will then take care of updating it when needed. I can take care of that part I think and will let you know once it's done. |
|
(sorry, just realized the yml is incorrect. Converted to draft to avoid it being merged) |
|
Ok, sorry for the mess. I created and merged #8425, #8426 and #8427 to fix a few things. Files are getting correctly hosted on the Hub: https://huggingface.co/datasets/diffusers/community-pipelines-mirror/tree/main 🎉 Workflow can be manually triggered on https://github.com/huggingface/diffusers/actions/workflows/mirror_community_pipeline.yml. |
|
Cool, would you mind updating our Slack channel about this? This is very nice move, indeed.
Perhaps we could set up automated reporting for this? |
Will do!
A CI checking if the CI failed? |
If the CI isn't successful, we will report the error to a Slack channel. |
|
Ah yes, makes sense. Do you have an example of how to do that? Happy to help but if you know how to do it/configure it, can I leave it to you? 🙏 |
|
This is how automated reporting is setup for a release: https://github.com/huggingface/diffusers/blob/main/.github/workflows/notify_slack_about_release.yml. I plan to update the benchmarking workflow and this workflow for automated reporting. But could be some days given the upcoming releases. |
|
Not a priority indeed! Good luck for the upcoming releases! |
* first draft * secret * tiktok * capital matters * dataset matter * don't be a prick * refact * only on main or tag * document with an example * Update destination dataset * link * allow manual trigger * better * lin --------- Co-authored-by: Sayak Paul <[email protected]>
Related to internal slack thread.
HF mirror example: https://huggingface.co/datasets/Wauplin/diffusers-community-pipelines-mirror. Each tag/branch is a subfolder with all the pipelines in it.
This PR adds a new CI workflow to host the community pipelines folder (
./examples/community) as an HF dataset. The HF dataset will only be a mirror of the content on Github and should be automatically updated by this CI. Action is triggered on commits on new tags (i.e. on new releases) and on commits onmainupdating the./examples/communityfolder.Once this will be done, we will be able to download community pipeline modules directly from the HF Hub instead of relying on Github files. This should simplify the logic as we will be able to use
hf_hub_downloadwhich handlescache_dir,force_download,local_files_only, etc... natively. Downloading from Github currently requires the deprecatedcached_downloadthat will soon be removed fromhuggingface_hub.TODO before merging: (by a
diffusersmaintainer)diffusers/community-pipelines-mirrorin the diffusers organization on the Hub.HF_TOKEN_MIRROR_COMMUNITY_PIPELINESin Github secretTODO once merged:
cached_downloadin a follow-up PR. See draft: Move away fromcached_download#8419