Skip to content

Fix PATH_IN_REPO on new release in mirror_community_pipeline.yaml #8519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wauplin merged 1 commit into from
Jun 13, 2024
+1 −1
Merged

Fix PATH_IN_REPO on new release in mirror_community_pipeline.yaml #8519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mirror_community_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
else
# e.g. refs/tags/v0.28.1 -> v0.28.1
echo "CHECKOUT_REF=${{ github.ref }}" >> $GITHUB_ENV
echo "PATH_IN_REPO=${${{ github.ref }}#refs/tags/}" >> $GITHUB_ENV
echo "PATH_IN_REPO=$(echo ${{ github.ref }} | sed 's/^refs\/tags\///')" >> $GITHUB_ENV
Copy link
Member

@sayakpaul sayakpaul Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky one. Thanks for taking care of this.

(side note: having an automated reporting mechanism would have promptly alerted us about this; so all the reasons for me to work on it soon)

Copy link
Collaborator Author

@Wauplin Wauplin Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely!

Even more subtle, the github action passed ( ✔️ ) but its behavior was wrong. When working on a reporting mechanism, it would be good to report values from PATH_IN_REPO/CHECKOUT_REF to slack as well.

fi
- name: Print env vars
run: |
Expand Down