-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Migrate to Gatsby 🚀 #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Gatsby 🚀 #896
Conversation
* prism-react-renderer * gatsby-background-image * title
Need to refactor this but for now it is there to get the job done
not needed
need to setup CNCF iframe
This allows to run specific page queries based on template and all the core logic is in one place
adding a new `sidebarOrder` field lets to specify a order instead of using an order given by query result
Hey @saihaj 👋🏼 Thanks so much for taking the initiative on this! I was talking with @IvanGoncharov and we were thinking of merging these changes into a new branch and then fix the missing parts/issues in additional PRs (we can track everything in the original issue - #875). That way, this PR doesn't become overwhelming and others can help get it to a place where we could then merge into What do you think? |
Hey @carolstran sounds good to me |
@saihaj Can you please rebase? |
Hey 👋🏼 @IvanGoncharov you are all set to deploy 🚀 it ! |
It needs another rebase but then pinging @IvanGoncharov again for this 💫 |
package.json
Outdated
"name": "graphql-docs-site", | ||
"description": "GraphQL Docs Site", | ||
"version": "0.1.0", | ||
"author": "Saihajpreet Singh <[email protected]>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through this again, I don't think we need an author
field here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad 🤦♂️ I was using one of my projects to make this and forgot to update. What about version number? Do we follow semantic versioning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I'm not super familiar with versioning in open source. Wdyt @IvanGoncharov?
@saihaj Thanks a lot for all your work 👍 |
I will open a PR so we can all coordinate. |
Summary
Migrate content to Gatsby site.
Preview -> https://graphql-docs-gatsby.vercel.app
What is left:
graphql-js
docsblog
Since Algolia and GA keys will go
.env
and need to set those accordingly in CI pipeline tooIssues that should be resolved before merging (🙏 Need Help 🙏 )
components/Layout.js
a div with some className is usedpages/index.js
:useEffect
hook is used to run the animations but the problem is when page changes it still runs for some reason and I don't know how to fix it. Update: I tried a clean up function to remove the child nodes but no good.css/Prism.less
gatsby-transformer-remark
seems to add className to<code>
tag which is causing border boxes around line. Need to remove those classnames somehow.gatsby-node.js
so that I can run one more query that will return title and one that returns content . When running it in GraphiQL (single query) the results are as expected but when I combine it with page query then the title is not correct.business_layer.png
: I forgot to add this when movinglearn
docsPossibly can refactor but don't know how to:
components/Sidebar/Sidebar.js
) and pass down data as props from a separate component that runs static query.templates
Closes #875