Skip to content

chore: update react to 16.12.0 #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

godcrampy
Copy link
Contributor

Changes Introduced:

  • add react-dom-factories as React.DOM.<element> is deprecated in react 16+
  • remove key warnings in element lists
  • update react to 16.12.0

Closes #776

@carolstran
Copy link
Member

👋🏼 @godcrampy, thanks for taking the time to open this pull request! While it's a great enhancement for the existing site, I believe that most of these issues will be solved with the migration to Gatsby (#896). That PR will be moved to its own branch and then cleaned up with additional PRs. If these issues are still present, then it would be best to tackle them there.

So I'm going to close this for now, but if you have any concerns or think I'm mistaken - let me know!

@carolstran carolstran closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update react-version
2 participants