Skip to content

Update react-version #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajkharvar opened this issue Oct 2, 2019 · 4 comments
Closed

Update react-version #776

rajkharvar opened this issue Oct 2, 2019 · 4 comments

Comments

@rajkharvar
Copy link

All the routes from https://graphql.org/learn/ are having outdated version of react. Please update it to the latest version.

@georgioupanayiotis
Copy link

Hi @rajkharvar ,
Do you mean react version on package.json ?

@rajkharvar
Copy link
Author

yes. react-dev-tools recommend updating to the latest version of react to avoid a nightmare.

@snitin315
Copy link

@rajkharvar can I work on this issue?

@carolstran
Copy link
Member

👋🏼 Thanks for this issue! I commented on the associated PR, but I'll drop a similar message here to keep the discussion in sync.

While I agree that this would be necessary for the existing site, the React version will be updated with the migration to Gatsby (#896) which is already on the roadmap. So I'm going to close this for now, but if you have any concerns or think I'm mistaken - let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants