Support posts with content-type application/x-www-form-urlencoded (#178) #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aphql-dotnet#178) Parse request body as form to extract GraphQLRequest properties. Fixes graphql-dotnet#178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse request body as form to extract GraphQLRequest properties.
Fixes #178
This change adds support for a common content-type and brings the library closer to parity with other popular GraphQL server implementations like express-graphql.
As an aside, the implementation of
HttpRequest.ReadFormAsyncalso handles posts with content-type multipart/form-data - I did not add this support here as I felt it was out of scope for the issue. I also don't have much experience with that content type and wasn't sure what additional work might be needed to parse the body.