Fix the issue when the client prematurely closes and the server canno… #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 8, 2018 17:14
…t complete the websocket reader pipeline
…lock for cases when CloseAsync fails because socket is in Aborted state
|
Well spotted! |
|
Can someone merge this fix? |
Contributor
|
There's a formatting issue in the PR. Perhaps someone using tabs instead of spaces.. |
Contributor
Author
|
Replaced tabs with spaces. |
Contributor
|
Still some formatting issues in the code. Functions wont align properly. Have you tried format document in VS? |
Contributor
Author
|
Hi Pekka. Yes, the code has been edited in VS. Fixed the alignment issue as well. |
adinKent
pushed a commit
to Conning/graphql-dotnet-server
that referenced
this pull request
Mar 4, 2021
graphql-dotnet#177) * Fix the issue when the client prematurely closes and the server cannot complete the websocket reader pipeline * Fix the issue when the client prematurely closed. Add a try/finally block for cases when CloseAsync fails because socket is in Aborted state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t complete the websocket reader pipeline
When a GraphQL client is subscribed and prematurely closes (e.g. the app crashes, or is simply closed), the WebSocketReaderPipeline tries to close the socket by calling _socket.CloseAsync which never returns.
Even though Microsoft's documentation on CloseAsync and CloseOutputAsync is quite similar, according to the below links:
CloseAsync waits for the client to acknowledge closing of the socket, whereas CloseOutputAsync works in fire-and-forget mode.
It looks like the use of those methods should be swapped to achieve the correct semantics, so that CloseAsync does not get stuck waiting for the client's acknowledgement (the client may already be closed by now) and hence never complete the reader pipeline.