Skip to content

test: fix DML system tests #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2020
Merged

test: fix DML system tests #388

merged 2 commits into from
Nov 16, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 16, 2020

Merge-on-green-bot "helpfully" merged #387 with failing system tests. This PR cleans those up.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #377 🦕

@tswast tswast requested review from a team and pmakani November 16, 2020 16:15
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 16, 2020
@tswast tswast requested review from shollyman and removed request for pmakani November 16, 2020 16:16
@tswast tswast mentioned this pull request Nov 16, 2020
Closed
@tswast tswast requested review from steffnay and removed request for shollyman November 16, 2020 19:31
@steffnay steffnay merged commit 9a9db54 into googleapis:master Nov 16, 2020
@tswast tswast deleted the issue377-dbapi-system-tests branch November 16, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@steffnay steffnay steffnay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @steffnay