Skip to content

test: fix DML system tests #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020
Merged

test: fix DML system tests #388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b61948
test: fix DML system tests
tswast Nov 16, 2020
ce6d961
Merge branch 'master' into issue377-dbapi-system-tests
tswast Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def test_close_releases_open_sockets(self):
client.close()

conn_count_end = len(current_process.connections())
self.assertEqual(conn_count_end, conn_count_start)
self.assertLessEqual(conn_count_end, conn_count_start)

def test_create_dataset(self):
DATASET_ID = _make_dataset_id("create_dataset")
Expand Down Expand Up @@ -1972,7 +1972,9 @@ def test_query_w_dml(self):
def test_dbapi_w_dml(self):
dataset_name = _make_dataset_id("dml_dbapi")
table_name = "test_table"
self._load_table_for_dml([("Hello World",)], dataset_name, table_name)
self._load_table_for_dml(
[("こんにちは",), ("Hello World",), ("Howdy!",)], dataset_name, table_name
)
query_template = """UPDATE {}.{}
SET greeting = 'Guten Tag'
WHERE greeting = 'Hello World'
Expand All @@ -1983,7 +1985,6 @@ def test_dbapi_w_dml(self):
job_id="test_dbapi_w_dml_{}".format(str(uuid.uuid4())),
)
self.assertEqual(Config.CURSOR.rowcount, 1)
self.assertIsNone(Config.CURSOR.fetchone())

def test_query_w_query_params(self):
from google.cloud.bigquery.job import QueryJobConfig
Expand Down