Skip to content

Commit 9a9db54

Browse files
authored
test: fix DML system tests (#388)
1 parent dc78edd commit 9a9db54

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/system.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def test_close_releases_open_sockets(self):
249249
client.close()
250250

251251
conn_count_end = len(current_process.connections())
252-
self.assertEqual(conn_count_end, conn_count_start)
252+
self.assertLessEqual(conn_count_end, conn_count_start)
253253

254254
def test_create_dataset(self):
255255
DATASET_ID = _make_dataset_id("create_dataset")
@@ -1972,7 +1972,9 @@ def test_query_w_dml(self):
19721972
def test_dbapi_w_dml(self):
19731973
dataset_name = _make_dataset_id("dml_dbapi")
19741974
table_name = "test_table"
1975-
self._load_table_for_dml([("Hello World",)], dataset_name, table_name)
1975+
self._load_table_for_dml(
1976+
[("こんにちは",), ("Hello World",), ("Howdy!",)], dataset_name, table_name
1977+
)
19761978
query_template = """UPDATE {}.{}
19771979
SET greeting = 'Guten Tag'
19781980
WHERE greeting = 'Hello World'
@@ -1983,7 +1985,6 @@ def test_dbapi_w_dml(self):
19831985
job_id="test_dbapi_w_dml_{}".format(str(uuid.uuid4())),
19841986
)
19851987
self.assertEqual(Config.CURSOR.rowcount, 1)
1986-
self.assertIsNone(Config.CURSOR.fetchone())
19871988

19881989
def test_query_w_query_params(self):
19891990
from google.cloud.bigquery.job import QueryJobConfig

0 commit comments

Comments
 (0)