samples: add support for CMMR Phase 2 #2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
customer managed instance configurations.
Unit tests each for create, update and delete instance config operations have been added.
user managed instance configs.
while creating instance config.
rajatbhatta
force-pushed
the
cmmr-samples
branch
from
3a3abc1 to
da965b8
Compare
rajatbhatta
force-pushed
the
cmmr-samples
branch
from
da965b8 to
4239a23
Compare
rajatbhatta
changed the title
rajatbhatta
force-pushed
the
cmmr-samples
branch
from
d1de3f9 to
274346d
Compare
rajatbhatta
requested review from
olavloite,
rahul2393,
ansh0l and
gauravpurohit06
|
Note: Tests will pass only when bom update is complete with the corresponding code changes in #1742. |
ansh0l
approved these changes
Sep 30, 2022
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
olavloite
approved these changes
Oct 3, 2022
samples/snippets/src/main/java/com/example/spanner/CreateInstanceConfigSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/DeleteInstanceConfigSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListInstanceConfigOperationsSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListInstanceConfigOperationsSample.java
Outdated
Show resolved
Hide resolved
…nceConfigSample.java Co-authored-by: Knut Olav Løite <[email protected]>
…eConfigOperationsSample.java Co-authored-by: Knut Olav Løite <[email protected]>
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
rajatbhatta
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following samples and corresponding tests have been added: