Skip to content

Commit 3a3abc1

Browse files
committed
fix: print statements in samples and IT
1 parent 8041d21 commit 3a3abc1

File tree

4 files changed

+17
-45
lines changed

4 files changed

+17
-45
lines changed

samples/snippets/src/main/java/com/example/spanner/CreateInstanceConfigSample.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ static void createInstanceConfig(
4949
.build()
5050
.getService()) {
5151
final InstanceAdminClient instanceAdminClient = spanner.getInstanceAdminClient();
52-
5352
final InstanceConfig baseConfig = instanceAdminClient.getInstanceConfig(baseInstanceConfig);
54-
5553
List<ReplicaInfo> readOnlyReplicas = ImmutableList.of(baseConfig.getOptionalReplicas().get(0));
5654

5755
InstanceConfigInfo instanceConfigInfo =
@@ -66,10 +64,10 @@ static void createInstanceConfig(
6664
try {
6765
System.out.printf("Waiting for operation on %s to complete...\n", instanceConfigId);
6866
InstanceConfig instanceConfig = operation.get(5, TimeUnit.MINUTES);
69-
System.out.printf("Created instance config %s\n", instanceConfig.getId());
67+
System.out.printf("Created instance configuration %s\n", instanceConfig.getId());
7068
} catch (ExecutionException | TimeoutException e) {
7169
System.out.printf(
72-
"Error: Creating instance config %s failed with error message %s\n",
70+
"Error: Creating instance configuration %s failed with error message %s\n",
7371
instanceConfigInfo.getId(), e.getMessage());
7472
} catch (InterruptedException e) {
7573
System.out.println(

samples/snippets/src/main/java/com/example/spanner/DeleteInstanceConfigSample.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,11 @@ static void deleteInstanceConfig(String projectId, String instanceConfigId) {
4141
try {
4242
System.out.printf("Waiting for operation on %s to complete...\n", instanceConfigId);
4343
instanceAdminClient.deleteInstanceConfig(instanceConfigId);
44-
System.out.printf("Deleted user instance config with id %s\n", instanceConfigId);
44+
System.out.printf("Deleted instance configuration %s\n", instanceConfigId);
4545
} catch (SpannerException e) {
4646
System.out.printf(
47-
"Could not delete user instance config %s: %s\n", instanceConfigId, e.getMessage());
47+
"Error: Deleting instance configuration %s failed with error message: %s\n",
48+
instanceConfigId, e.getMessage());
4849
}
4950
}
5051
}

samples/snippets/src/main/java/com/example/spanner/UpdateInstanceConfigSample.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,10 @@ static void updateInstanceConfig() {
3636
// TODO(developer): Replace these variables before running the sample.
3737
String projectId = "my-project";
3838
String instanceConfigId = "custom-instance-config";
39-
String displayName = "my-display-name";
40-
updateInstanceConfig(projectId, instanceConfigId, displayName);
39+
updateInstanceConfig(projectId, instanceConfigId);
4140
}
4241

43-
static void updateInstanceConfig(String projectId, String instanceConfigId, String displayName) {
42+
static void updateInstanceConfig(String projectId, String instanceConfigId) {
4443
try (Spanner spanner =
4544
SpannerOptions.newBuilder()
4645
.setProjectId(projectId)
@@ -50,18 +49,20 @@ static void updateInstanceConfig(String projectId, String instanceConfigId, Stri
5049

5150
InstanceConfigInfo instanceConfigInfo =
5251
InstanceConfig.newBuilder(InstanceConfigId.of(projectId, instanceConfigId))
53-
.setDisplayName(displayName)
52+
.setDisplayName("updated custom instance config")
53+
.addLabel("updated", "true")
5454
.build();
5555

5656
final OperationFuture<InstanceConfig, UpdateInstanceConfigMetadata> operation =
5757
instanceAdminClient.updateInstanceConfig(
58-
instanceConfigInfo, ImmutableList.of(InstanceConfigField.DISPLAY_NAME));
58+
instanceConfigInfo,
59+
ImmutableList.of(InstanceConfigField.DISPLAY_NAME, InstanceConfigField.LABELS));
5960

6061
try {
6162
System.out.printf("Waiting for operation on %s to complete...\n", instanceConfigId);
6263
InstanceConfig instanceConfig = operation.get(5, TimeUnit.MINUTES);
6364
System.out.printf(
64-
"Updated instance config %s with new display name %s\n",
65+
"Updated instance configuration %s with new display name %s\n",
6566
instanceConfig.getId(), instanceConfig.getDisplayName());
6667
} catch (ExecutionException | TimeoutException e) {
6768
System.out.printf(

samples/snippets/src/test/java/com/example/spanner/CustomInstanceConfigSampleIT.java

Lines changed: 5 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -32,56 +32,28 @@ public void testCustomInstanceConfigOperations() throws Exception {
3232
() ->
3333
CreateInstanceConfigSample.createInstanceConfig(
3434
projectId, instanceConfigName, customInstanceConfigId));
35-
assertTrue(
36-
"Expected instance config "
37-
+ customInstanceConfigId
38-
+ " to be created."
39-
+ " Output received was "
40-
+ out1,
41-
out1.contains(customInstanceConfigId));
35+
assertTrue(out1.contains("Created instance configuration"));
4236

4337
// List the instance config operations.
4438
final String out2 =
4539
SampleRunner.runSample(
4640
() ->
4741
ListInstanceConfigOperationsSample.listInstanceConfigOperations(projectId));
48-
assertTrue(
49-
"Expected to list instance config for project: "
50-
+ projectId
51-
+ ". Output received was "
52-
+ out2,
53-
out2.contains(customInstanceConfigId));
42+
assertTrue(out2.contains("List instance config operation"));
5443

5544
// Update display name to a randomly generated instance config id.
56-
String newDisplayName = idGenerator.generateInstanceConfigId();
5745
final String out3 =
5846
SampleRunner.runSample(
5947
() ->
6048
UpdateInstanceConfigSample.updateInstanceConfig(
61-
projectId, customInstanceConfigId, newDisplayName));
62-
assertTrue(
63-
"Expected display name to be updated from "
64-
+ customInstanceConfigId
65-
+ " to "
66-
+ newDisplayName
67-
+ " for instance config "
68-
+ customInstanceConfigId
69-
+ "."
70-
+ " Output received was "
71-
+ out3,
72-
out3.contains(newDisplayName));
49+
projectId, customInstanceConfigId));
50+
assertTrue(out3.contains("Updated instance configuration"));
7351

7452
// Delete the created instance config.
7553
final String out4 =
7654
SampleRunner.runSample(
7755
() ->
7856
DeleteInstanceConfigSample.deleteInstanceConfig(projectId, customInstanceConfigId));
79-
assertTrue(
80-
"Expected instance config "
81-
+ customInstanceConfigId
82-
+ " to be deleted."
83-
+ " Output received was "
84-
+ out4,
85-
out4.contains(customInstanceConfigId));
57+
assertTrue(out4.contains("Deleted instance configuration"));
8658
}
8759
}

0 commit comments

Comments
 (0)