feat: support customer managed instance configurations #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
|
Warning: This pull request is touching the following templated files:
|
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
customer managed instance configurations.
Unit tests each for create, update and delete instance config operations have been added.
user managed instance configs.
rajatbhatta
added
the
do not merge
while creating instance config.
olavloite
approved these changes
Apr 4, 2022
|
Hi @thiagotnunes @olavloite : I've added support (both implementation and tests) for ListInstanceConfigOperations as well to this PR. Can you please review changes since previous code review? Thank you! |
olavloite
approved these changes
May 3, 2022
Thanks for the review! Yes, we'll add end-to-end tests in a separate PR, along with the samples. We'll be writing integration tests using those samples (like in other clients). |
rajatbhatta
removed
the
do not merge
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
rajatbhatta
changed the title
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
🤖 I have created a release *beep* *boop* --- ## [6.31.0](https://togithub.com/googleapis/java-spanner/compare/v6.30.2...v6.31.0) (2022-09-29) ### Features * Support customer managed instance configurations ([#1742](https://togithub.com/googleapis/java-spanner/issues/1742)) ([c1c805c](https://togithub.com/googleapis/java-spanner/commit/c1c805cf6e9c00f2d6796627d919338be1a0599a)) ### Dependencies * Update dependency com.google.cloud:google-cloud-trace to v2.3.4 ([#2027](https://togithub.com/googleapis/java-spanner/issues/2027)) ([14890ed](https://togithub.com/googleapis/java-spanner/commit/14890ed8e0df99eba7c2521a196132c78054b6ed)) * Update dependency com.google.cloud:google-cloud-trace to v2.3.5 ([#2083](https://togithub.com/googleapis/java-spanner/issues/2083)) ([cef4e0a](https://togithub.com/googleapis/java-spanner/commit/cef4e0ada98ab65020f32836fc0c8ab1ee0c7eed)) * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.14 ([#2030](https://togithub.com/googleapis/java-spanner/issues/2030)) ([04b59ff](https://togithub.com/googleapis/java-spanner/commit/04b59ff8a1efaa32082aa4e9567d90b5956810c6)) * Update dependency org.json:json to v20220924 ([#2035](https://togithub.com/googleapis/java-spanner/issues/2035)) ([a26a14a](https://togithub.com/googleapis/java-spanner/commit/a26a14a94ac3ca6cd7eabce6826cce3dde27ea66)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the functionality for CMMR Phase 2. Here we do the following:
Adds support for new fields optionalReplicas, baseConfig, labels, etag, reconciling, state, configType in InstanceConfigInfo class.
Adds Builder class for InstanceConfigInfo.
Adds an InstanceConfigField class (which extends from FieldMask). This can be used to specify a subset of fields to be modified during update operation.
Adds Builder class for InstanceConfig.
Changes to Rpc interface/class to add support for Create, Update and Delete instance config operations.
Adds createInstanceConfig, updateInstanceConfig, and deleteInstanceConfig methods to InstanceAdminClient interface.
Provide implementations for createInstanceConfig, updateInstanceConfig, and deleteInstanceConfig methods in InstanceAdminClientImpl class. These methods call the corresponding Rpc methods, which are responsible for making the Rpc calls.