Use GTMAppAuth's new delegate protocol #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch40w31
requested changes
Apr 12, 2023
ch40w31
requested changes
Apr 13, 2023
paulb777
reviewed
Apr 13, 2023
paulb777
reviewed
Apr 14, 2023
Member
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
CocoaPods and SPM config changes LGTM.
mdmathias
force-pushed
the
mdmathias/gtmaa-error-handling
branch
from
0764b95 to
bb10b39
Compare
XiangtianDai
approved these changes
May 9, 2023
Stub GTMKeychainStore saveAuthSession method to sometimes succeed and sometimes fill in an error.
Also add an empty Swift file for CocoaPods in SignInSample
Xcode was warning that GIDAuthStateMigration did not override the designated initializer of the superclass.
… test case category
This updated name makes it more explicit that we expect the fetch to fail and that we want to inspect the error in the completion handler.
This change supports CocoaPods using a host application for running tests.
mdmathias
force-pushed
the
mdmathias/gtmaa-error-handling
branch
from
0015161 to
2dab4df
Compare
ch40w31
requested changes
May 16, 2023
Also use ivar in GIDGoogleUser init instead of accessing via self.
ch40w31
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTMAppAuth added a new protocol to provide an interface for dependencies to both add additional token refresh parameters and update errors issued by GTMAppAuth. The latter is especially for the case of EMM error handling.
Fixes #304