Add a method taking a completion argument for asynchronous error updates #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
One potential issue here that we may want to consider is that @ch40w31 thoughts? |
Trying this to see if the removed check was causing pod lib lint issues on GitHub.
mdmathias
force-pushed
the
mdmathias/update-error-completion
branch
from
691cd4d to
e82bf0d
Compare
Collaborator
Author
|
Please disregard #229 (comment). Took a direction that should avoid the problem. |
This change ensures that the callback closure is called if the delegate doesn't implement the optional method.
ch40w31
reviewed
May 3, 2023
ch40w31
reviewed
May 3, 2023
ch40w31
reviewed
May 3, 2023
…d method from test helper
ch40w31
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a completion argument for handling updated errors in EMM flow (e.g., google/GoogleSignIn-iOS#299).