Make AuthSession final and add a delegate protocol to intercept and provide custom errors #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petea
reviewed
Jan 19, 2023
This was referenced Mar 27, 2023
This change simply forwards the error received from the AuthSession delegate to the original caller
mdmathias
force-pushed
the
mdmathias/no-longer-open
branch
from
9b669d6 to
4721699
Compare
ch40w31
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by the fact that Swift classes (even
@objcandNSObjectsubclasses) cannot themselves be subclassed in Objective-C. Thus, we need to provide some mechanism for GSI-iOS to receive, and potentially modify, errors before they are delivered to the clients. The delegate protocol added here is that solution.