This repository was archived by the owner on Jun 2, 2023. It is now read-only.
Testing #39
Open
Testing #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
commented
Jun 24, 2018
| func BadFunc() { | ||
| if true { | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
| @@ -45,6 +45,14 @@ var testPR = &gh.PullRequest{ | |||
| } | |||
| var testAnalysisGUID = "test-guid" | |||
|
|
|||
| func BadFunc() { | |||
There was a problem hiding this comment.
File is not goimports-ed
golangci
commented
Jun 24, 2018
| func BadFunc2() { | ||
| if false { | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
| } | ||
| } | ||
|
|
||
| func BadFunc2() { |
There was a problem hiding this comment.
func BadFunc2 is unused
jirfag
force-pushed
the
master
branch
2 times, most recently
from
e557432 to
93bb034
Compare
jirfag
force-pushed
the
master
branch
4 times, most recently
from
9d4340e to
15c38dd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.