fix builds

Author: jirfag

.circleci/config.yml

@@ -6,7 +6,7 @@ jobs:
   build:
     docker:
       # specify the version
-      - image: circleci/golang:1.9
+      - image: circleci/golang:1.11
       - image: redis
 
       # Specify service dependencies here if necessary

.golangci.yml

@@ -21,3 +21,6 @@ linters:
     - prealloc
     - dupl # temporary
     - gosec
+    - scopelint
+    - gochecknoglobals
+    - gochecknoinits

app/lib/executors/shell.go

@@ -138,8 +138,6 @@ func (s shell) runAsync(ctx context.Context, name string, args ...string) (int,
 		return 0, nil, nil, err
 	}
 
-	return cmd.Process.Pid, outReader, func() error {
-		// XXX: it's important to not change error here, because it holds exit code
-		return cmd.Wait()
-	}, nil
+	// XXX: it's important to not change error here, because it holds exit code
+	return cmd.Process.Pid, outReader, cmd.Wait, nil
 }