Skip to content
This repository was archived by the owner on Jun 2, 2023. It is now read-only.

Testing #39

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Testing #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e562b3
just testing
jirfag Jun 21, 2018
85e11e6
fix
jirfag Jun 21, 2018
9e1255c
fix
jirfag Jun 21, 2018
b9f2cfd
add bad file
jirfag Jun 24, 2018
2dd4cf5
mv
jirfag Jun 24, 2018
b9fed31
issues
jirfag Jun 24, 2018
fbd0d7b
more issues
jirfag Jun 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions app/analyze/processors/github_go_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,22 @@ var testPR = &gh.PullRequest{
}
var testAnalysisGUID = "test-guid"

func BadFunc() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is not goimports-ed

if true {
return
} else {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if block ends with a return statement, so drop this else and outdent its block

getNopFetcher(nil)
}
}

func BadFunc2() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func BadFunc2 is unused

if false {
return
} else {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if block ends with a return statement, so drop this else and outdent its block

getNopFetcher(nil)
}
}

func getFakeLinters(ctrl *gomock.Controller, issues ...result.Issue) []linters.Linter {
a := linters.NewMockLinter(ctrl)
a.EXPECT().
Expand Down
1 change: 1 addition & 0 deletions badpkg/bad.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
trash is here