tests: configure github remaining limit + read token #9800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
added
topic/build
|
This currently doesn't work because we already are over API rates. I think I could create a function to refresh api rate before. |
GiteaBot
added
the
lgtm/need 2
|
Another improvement, could also to call RefreshRate if rate is nil in sleep function. |
|
While other jobs aren't filtering it will still keep failing when they consume the full api rate in parallel. |
zeripath
approved these changes
Jan 16, 2020
GiteaBot
added
lgtm/need 1
sapk
changed the title
sapk
added
type/testing
topic/build
|
Now the test use GITHUB_READ_TOKEN env variable as access token (empty by default) |
|
I added github_read_token (user https://github.com/gitea-test with only read email) to drone |
sapk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9800 +/- ##
=========================================
+ Coverage 42.19% 42.29% +0.1%
=========================================
Files 603 603
Lines 78868 78868
=========================================
+ Hits 33278 33359 +81
+ Misses 41511 41419 -92
- Partials 4079 4090 +11
Continue to review full report at Codecov.
|
guillep2k
approved these changes
Jan 16, 2020
GiteaBot
added
lgtm/done
|
I have merged #9796 before this one to re-validate that it passed with the token will others are failing. |
|
Now CI failed for an other reason on sqlite test ... It will never end 😄 |
|
and it passed 👍 |
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Jan 19, 2020
* ci: configure remaining github limmit * prepend with github since package is common to all migrations * add RefreshRate * Update github.go * add missing space * go fmt * Read env variable GITHUB_READ_TOKEN for token * Update .drone.yml
sapk
added a commit
that referenced
this pull request
Jan 19, 2020
* ci: use docker image for golangci-lint (#9737) * ci: re-ordering Drone CI for optimizing time (#9719) * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try offloading mysql8 to arm64 * Revert "ci: try offloading mysql8 to arm64" This reverts commit c60de5d. * ci: try offloading pgsql to arm64 * ci: activate ldap on arm64 * ci: test mysql8 in place pgsql arm64 * chore: clean un-needed move * typo * ci: revert runnning mysql on arm64 * ci: run compliance on arm * chore: limit change * chore: readd maybe need for release fetch-tags * ci: remove docker-linux-amd64-dry-run * ci: remove docker-linux-amd64-dry-run * Revert "ci: remove docker-linux-amd64-dry-run" This reverts commit 0715f65. Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> * ci: use new mssql image (#9720) Co-authored-by: Lunny Xiao <[email protected]> * ci: run notify on arm64 (#9762) * ci: run notify on arm64 Free one jobs on amrd64 * Update .drone.yml * Update .drone.yml * Update .drone.yml Based on: https://github.com/appleboy/drone-discord/blob/master/.drone.yml#L339 * improve trigger Co-authored-by: techknowlogick <[email protected]> * ci: move some integration tests on arm64 (#9747) * tests: configure github remaining limit + read token (#9800) * ci: configure remaining github limmit * prepend with github since package is common to all migrations * add RefreshRate * Update github.go * add missing space * go fmt * Read env variable GITHUB_READ_TOKEN for token * Update .drone.yml * ci: simplify tag/release by always running coverage (#9774) * ci: simplify tag/release by always running coverage * use mod and vendor for unit test coverage * remove not needed lfs for unit test * use arm drone agent for docs (#9776) * run translations pipeline on arm server (#9865) * add git-check to Makefile Co-authored-by: Antoine GIRARD <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not trigger API limits in CI,
This is a simple configuration to not failed when we have 3 running jobs of unit-test in parallel for CI.
We should also provide a github key (I think I have the rights to do it) with minimum permission to increase the limit and not have to wait.Done!