Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 14, 2020

  • Free one jobs on amd64 (to win some time to start testing on amd64 of an other jobs)
  • Update discord plugin to latest version.
    • Support more paltform (including arm64)
    • Support upload of file if needed
    • Update deps and base docker image

Changelog: appleboy/drone-discord@1.0.0...v1.2.4

Free one jobs on amrd64
@sapk sapk added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 14, 2020
@sapk
Copy link
Member Author

sapk commented Jan 14, 2020

I don't exactly know why this doesn't work and complain about:

2020/01/14 16:10:27 missing discord config

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2020
@sapk
Copy link
Member Author

sapk commented Jan 14, 2020

Since it change of host maybe it need to be allowed by owners ?

@sapk
Copy link
Member Author

sapk commented Jan 14, 2020

Ok so this was already not working before: https://drone.gitea.io/go-gitea/gitea/19367/5/1 (thanks @techknowlogick for the insight).
So I enabled it only on master and tags.
I also taken some config from plugin .drone.yml https://github.com/appleboy/drone-discord/blob/master/.drone.yml#L339

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2020
@sapk
Copy link
Member Author

sapk commented Jan 14, 2020

I will have to adjust the conditions here since I think I am missing releases branches. done

@codecov-io
Copy link

codecov-io commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b6fd6be). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9762   +/-   ##
=========================================
  Coverage          ?   42.32%           
=========================================
  Files             ?      600           
  Lines             ?    78357           
  Branches          ?        0           
=========================================
  Hits              ?    33166           
  Misses            ?    41136           
  Partials          ?     4055

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fd6be...9171d27. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2020
@sapk sapk merged commit fd76170 into go-gitea:master Jan 15, 2020
@sapk sapk deleted the ci-notify-arm64 branch January 15, 2020 02:14
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jan 19, 2020
* ci: run notify on arm64

Free one jobs on amrd64

* Update .drone.yml

* Update .drone.yml

* Update .drone.yml

Based on: https://github.com/appleboy/drone-discord/blob/master/.drone.yml#L339

* improve trigger

Co-authored-by: techknowlogick <[email protected]>
sapk added a commit that referenced this pull request Jan 19, 2020
* ci: use docker image for golangci-lint (#9737)

* ci: re-ordering Drone CI for optimizing time (#9719)

* ci: try re-ordering for optimizing time

* ci: try re-ordering for optimizing time

* ci: try re-ordering for optimizing time

* ci: try re-ordering for optimizing time

* ci: try re-ordering for optimizing time

* ci: try re-ordering for optimizing time

* ci: try offloading mysql8 to arm64

* Revert "ci: try offloading mysql8 to arm64"

This reverts commit c60de5d.

* ci: try offloading pgsql to arm64

* ci: activate ldap on arm64

* ci: test mysql8 in place pgsql arm64

* chore: clean un-needed move

* typo

* ci: revert runnning mysql on arm64

* ci: run compliance on arm

* chore: limit change

* chore: readd maybe need for release fetch-tags

* ci: remove docker-linux-amd64-dry-run

* ci: remove docker-linux-amd64-dry-run

* Revert "ci: remove docker-linux-amd64-dry-run"

This reverts commit 0715f65.

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>

* ci: use new mssql image (#9720)

Co-authored-by: Lunny Xiao <[email protected]>

* ci: run notify on arm64 (#9762)

* ci: run notify on arm64

Free one jobs on amrd64

* Update .drone.yml

* Update .drone.yml

* Update .drone.yml

Based on: https://github.com/appleboy/drone-discord/blob/master/.drone.yml#L339

* improve trigger

Co-authored-by: techknowlogick <[email protected]>

* ci: move some integration tests on arm64 (#9747)

* tests: configure github remaining limit + read token (#9800)

* ci: configure remaining github limmit

* prepend with github since package is common to all migrations

* add RefreshRate

* Update github.go

* add missing space

* go fmt

* Read env variable GITHUB_READ_TOKEN for token

* Update .drone.yml

* ci: simplify tag/release by always running coverage (#9774)

* ci: simplify tag/release by always running coverage

* use mod and vendor for unit test coverage

* remove not needed lfs for unit test

* use arm drone agent for docs (#9776)

* run translations pipeline on arm server (#9865)

* add git-check to Makefile

Co-authored-by: Antoine GIRARD <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants