ci: simplify tag/release by always running coverage #9774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
added
topic/build
|
I haven't maid my mind if coverage should be uploaded for releases so I didn't change this part so that coverage are still only uploaded for pr and push on master. |
GiteaBot
added
the
lgtm/need 2
|
This PR fix also :
|
Codecov Report
@@ Coverage Diff @@
## master #9774 +/- ##
==========================================
+ Coverage 42.2% 42.22% +0.02%
==========================================
Files 603 603
Lines 78863 78885 +22
==========================================
+ Hits 33281 33309 +28
+ Misses 41505 41500 -5
+ Partials 4077 4076 -1
Continue to review full report at Codecov.
|
zeripath
approved these changes
Jan 15, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Jan 15, 2020
GiteaBot
added
lgtm/done
|
|
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Jan 19, 2020
* ci: simplify tag/release by always running coverage * use mod and vendor for unit test coverage * remove not needed lfs for unit test
sapk
added a commit
that referenced
this pull request
Jan 19, 2020
* ci: use docker image for golangci-lint (#9737) * ci: re-ordering Drone CI for optimizing time (#9719) * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try re-ordering for optimizing time * ci: try offloading mysql8 to arm64 * Revert "ci: try offloading mysql8 to arm64" This reverts commit c60de5d. * ci: try offloading pgsql to arm64 * ci: activate ldap on arm64 * ci: test mysql8 in place pgsql arm64 * chore: clean un-needed move * typo * ci: revert runnning mysql on arm64 * ci: run compliance on arm * chore: limit change * chore: readd maybe need for release fetch-tags * ci: remove docker-linux-amd64-dry-run * ci: remove docker-linux-amd64-dry-run * Revert "ci: remove docker-linux-amd64-dry-run" This reverts commit 0715f65. Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> * ci: use new mssql image (#9720) Co-authored-by: Lunny Xiao <[email protected]> * ci: run notify on arm64 (#9762) * ci: run notify on arm64 Free one jobs on amrd64 * Update .drone.yml * Update .drone.yml * Update .drone.yml Based on: https://github.com/appleboy/drone-discord/blob/master/.drone.yml#L339 * improve trigger Co-authored-by: techknowlogick <[email protected]> * ci: move some integration tests on arm64 (#9747) * tests: configure github remaining limit + read token (#9800) * ci: configure remaining github limmit * prepend with github since package is common to all migrations * add RefreshRate * Update github.go * add missing space * go fmt * Read env variable GITHUB_READ_TOKEN for token * Update .drone.yml * ci: simplify tag/release by always running coverage (#9774) * ci: simplify tag/release by always running coverage * use mod and vendor for unit test coverage * remove not needed lfs for unit test * use arm drone agent for docs (#9776) * run translations pipeline on arm server (#9865) * add git-check to Makefile Co-authored-by: Antoine GIRARD <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that test-mysql were skipped for releases branches as target: https://drone.gitea.io/go-gitea/gitea/19379 and https://drone.gitea.io/go-gitea/gitea/19390
At first I was thinking of adding the branches target but I think it was more simple to just remove all the complexity (also for unit tests) just to not run the coverage (which should take much time and only for few commits)
This PR fix also :