-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Remove unnecessary permissions load #9796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sapk
merged 4 commits into
go-gitea:master
from
lunny:lunny/remove_unnecessary_perm_load
Jan 16, 2020
Merged
Remove unnecessary permissions load #9796
sapk
merged 4 commits into
go-gitea:master
from
lunny:lunny/remove_unnecessary_perm_load
Jan 16, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9796 +/- ##
==========================================
- Coverage 42.19% 42.17% -0.03%
==========================================
Files 603 603
Lines 78859 78862 +3
==========================================
- Hits 33277 33258 -19
- Misses 41507 41526 +19
- Partials 4075 4078 +3
Continue to review full report at Codecov.
|
zeripath
approved these changes
Jan 16, 2020
guillep2k
approved these changes
Jan 16, 2020
6543
approved these changes
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a request to a route with
repoassignment
middleware, a permission will be loaded toctx.Repo.Permission
. So we could directly use that but not load it again.This PR will remove these unnecessary permissions load.