modules/context/auth.go: fix redirect loop

[xdch47]

Closes #5815

Heatmap loop still persists.

[zeripath]

Heya! I've actually just tested this on my own server and noticed the bug. It's not good that this was missed - I'm sorry about that.

We should probably change our integration tests to ensure we hit these potential bugs - always query Gitea without the suburl but always expect the suburl back etc.

In terms of fixing the other redirects - perhaps we should add a redirected from Param to the query and if we end up attempting to redirect back to the same place we should return forbidden.

[codecov-io]

Codecov Report

Merging #5965 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5965      +/-   ##
==========================================
+ Coverage   38.86%   38.86%   +<.01%     
==========================================
  Files         345      345              
  Lines       49508    49508              
==========================================
+ Hits        19241    19243       +2     
+ Misses      27485    27482       -3     
- Partials     2782     2783       +1

Impacted Files	Coverage Δ
modules/context/auth.go	21.87% <0%> (ø)	⬆️
models/unit.go	14.28% <0%> (+14.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b72c00...eba5b05. Read the comment docs.

[lunny]

Please send back port to release/v1.7

[mckaygerhard]

this change makes works the problem in #5482

[erpadmin]

how can i determine if when this will hit binary release? i'm having this issue on httpd although working w/colleague to determine our current version

[apricote]

This was included as a backport in v1.7.3 and will be included in the next minor version v1.8.0.