modules/context/auth.go: fix redirect loop (go-gitea#5965)

xdch47 · xdch47 · commit 01bb3addd44a · 2019-02-17T09:48:09.000+01:00
Closes go-gitea#5815
diff --git a/modules/context/auth.go b/modules/context/auth.go
@@ -42,7 +42,7 @@ func Toggle(options *ToggleOptions) macaron.Handler {
 			// prevent infinite redirection
 			// also make sure that the form cannot be accessed by
 			// users who don't need this
-			if ctx.Req.URL.Path == setting.AppSubURL+"/user/settings/change_password" {
+			if ctx.Req.URL.Path == "/user/settings/change_password" {
 				if !ctx.User.MustChangePassword {
 					ctx.Redirect(setting.AppSubURL + "/")
 				}

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func Toggle(options *ToggleOptions) macaron.Handler {`
`42`	`42`	`// prevent infinite redirection`
`43`	`43`	`// also make sure that the form cannot be accessed by`
`44`	`44`	`// users who don't need this`
`45`		`- if ctx.Req.URL.Path == setting.AppSubURL+"/user/settings/change_password" {`
	`45`	`+ if ctx.Req.URL.Path == "/user/settings/change_password" {`
`46`	`46`	`if !ctx.User.MustChangePassword {`
`47`	`47`	`ctx.Redirect(setting.AppSubURL + "/")`
`48`	`48`	`}`