Skip to content

modules/context/auth.go: fix redirect loop #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2019
Merged

modules/context/auth.go: fix redirect loop #5965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c99d65
modules/context/auth.go: fix redirect loop
xdch47 Feb 4, 2019
eba5b05
Merge branch 'master' into master
lunny Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/context/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func Toggle(options *ToggleOptions) macaron.Handler {
// prevent infinite redirection
// also make sure that the form cannot be accessed by
// users who don't need this
if ctx.Req.URL.Path == setting.AppSubURL+"/user/settings/change_password" {
if ctx.Req.URL.Path == "/user/settings/change_password" {
Copy link

@mckaygerhard mckaygerhard Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change makes works the problem in #5482

if !ctx.User.MustChangePassword {
ctx.Redirect(setting.AppSubURL + "/")
}
Expand Down