Skip to content

Fix leaky tests. #148434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2024
Merged

Fix leaky tests. #148434

merged 2 commits into from
May 15, 2024

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented May 15, 2024 •
edited
Loading

Introduced by #148265

Screenshot 2024-05-15 at 3 15 44 PM

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label May 15, 2024
@polina-c polina-c requested a review from justinmc May 15, 2024 22:14
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 15, 2024
justinmc
justinmc approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@polina-c polina-c merged commit 86eecd3 into flutter:master May 15, 2024
@polina-c polina-c deleted the fix-leak branch May 15, 2024 23:52
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 16, 2024
@hello-coder-xu
Merge branch 'master' into fix/gridview_delegate
e75b224 
* master: (2580 commits)
  plugin_ffi template comment fix (flutter#148378)
  Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter#148455)
  Reland fix TextField helper top padding on M3 (flutter#146754)
  Removing duplicate assert on `VisualDensity` constructor (flutter#148281)
  Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter#148450)
  Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter#148448)
  Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter#148445)
  Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter#148441)
  Fix leaky tests. (flutter#148434)
  Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter#148430)
  Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter#148428)
  Update _handlePushRouteInformation to Future<bool>  to indicate whether any of the observer has handled the route or not (flutter#147901)
  Fix memory leaks in `_PopupMenuRoute` (flutter#148373)
  Add `clipBehavior` to `DrawerThemeData` (flutter#148061)
  Reland Native ios context menu (flutter#143002) (flutter#148238) (flutter#148265)
  Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter#148419)
  Stop running module_test_ios in devicelab and x64 Macs (flutter#148264)
  Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter#148369)
  Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter#148367)
  Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter#148365)
  ...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2024
@engine-flutter-autoroll
86eecd3 Fix leaky tests. (flutter/flutter#148434)
60e7134
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2024
@engine-flutter-autoroll
86eecd3 Fix leaky tests. (flutter/flutter#148434)
63b8464
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 16, 2024
@engine-flutter-autoroll
Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (#6748)
7d0f88f 
flutter/flutter@39651e8...0d22d91

2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816)
2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476)
2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469)
2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465)
2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408)
2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403)
2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378)
2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455)
2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754)
2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281)
2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450)
2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448)
2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445)
2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441)
2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434)
2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430)
2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428)
2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool>  to indicate whether any of the observer has handled the route or not (flutter/flutter#147901)
2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373)
2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061)
2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265)
2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419)
2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 17, 2024
Closed
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (flutter#6748)
c15efcf 
flutter/flutter@39651e8...0d22d91

2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816)
2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476)
2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469)
2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465)
2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408)
2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403)
2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378)
2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455)
2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754)
2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281)
2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450)
2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448)
2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445)
2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441)
2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434)
2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430)
2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428)
2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool>  to indicate whether any of the observer has handled the route or not (flutter/flutter#147901)
2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373)
2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061)
2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265)
2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419)
2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
86eecd3 Fix leaky tests. (flutter/flutter#148434)
223685f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-c @justinmc