Skip to content

Reland fix TextField helper top padding on M3 #146754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

Reland fix TextField helper top padding on M3 #146754

merged 1 commit into from
May 16, 2024

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Apr 15, 2024

This is a reland of #145087 which was reverted in #145168.

#146637 was merged and might help here.

Description

InputDecorator adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.

This PR sets the correct values for M3 without changing the value for M2.

Before After M3 Spec
image image image

If this change is accepted, a future step will be to make this value configurable, probably by InputDecorationTheme.

Related Issue

Fixes #144984

Tests

Updates a value used by several existing tests.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 15, 2024
@bleroux bleroux requested a review from justinmc April 15, 2024 11:54
@bleroux
Copy link
Contributor Author

bleroux commented Apr 15, 2024

@justinmc Let's see if this is ok now that #146637 has landed 🤞

@justinmc
Copy link
Contributor

Google testing started 🤞

@bleroux
Copy link
Contributor Author

bleroux commented Apr 17, 2024

@justinmc Google testing failed but did it failed on the contrast test that led to the previous revert?

@bleroux bleroux requested a review from Renzo-Olivares April 30, 2024 13:32
@bleroux
Copy link
Contributor Author

bleroux commented Apr 30, 2024

@Renzo-Olivares If you have some bandwith can you have a look to the Google testing failure on this PR.

For context, this is a reland which was reverted due to an accessibility test failure, see #145087 (comment).

In the meantime, #146637 landed so Justin and I wonder if this accessibility test is still failing?

@justinmc
Copy link
Contributor

justinmc commented May 2, 2024

Google test failures are expected due to the visual change, but we need to figure out whether the accessibility failure is still there or not. I will plan to go through those next week and see.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@justinmc
Copy link
Contributor

justinmc commented May 9, 2024

I don't see the accessibility test failure, and I've checked all of the failing image diff tests and they're all expected. Let's try merging this.

@bleroux
Copy link
Contributor Author

bleroux commented May 9, 2024

I don't see the accessibility test failure, and I've checked all of the failing image diff tests and they're all expected. Let's try merging this.

@justinmc Thanks a lot for checking this and above all for pointing the right direction in #145087 (comment). 🙏
Let see if this change sticks without a revert in the coming days 🤞

@bleroux
Copy link
Contributor Author

bleroux commented May 9, 2024

@justinmc Looks like you added the auto submit label but forgot to approve the PR.

justinmc
justinmc approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sorry I thought I had already approved 😊 . I'll plan to merge this tomorrow morning to be sure I'm available in case it breaks anything.

@bleroux bleroux added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels May 16, 2024
@auto-submit auto-submit bot merged commit b1677f6 into flutter:master May 16, 2024
hello-coder-xu pushed a commit to hello-coder-xu/flutter that referenced this pull request May 16, 2024
Merge branch 'master' into fix/fix_slider_text_null_error
5b24378 
* master:
  plugin_ffi template comment fix (flutter#148378)
  Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter#148455)
  Reland fix TextField helper top padding on M3 (flutter#146754)
  Removing duplicate assert on `VisualDensity` constructor (flutter#148281)
  Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter#148450)
  Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter#148448)
  Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter#148445)
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 16, 2024
@hello-coder-xu
Merge branch 'master' into fix/gridview_delegate
e75b224 
* master: (2580 commits)
  plugin_ffi template comment fix (flutter#148378)
  Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter#148455)
  Reland fix TextField helper top padding on M3 (flutter#146754)
  Removing duplicate assert on `VisualDensity` constructor (flutter#148281)
  Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter#148450)
  Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter#148448)
  Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter#148445)
  Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter#148441)
  Fix leaky tests. (flutter#148434)
  Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter#148430)
  Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter#148428)
  Update _handlePushRouteInformation to Future<bool>  to indicate whether any of the observer has handled the route or not (flutter#147901)
  Fix memory leaks in `_PopupMenuRoute` (flutter#148373)
  Add `clipBehavior` to `DrawerThemeData` (flutter#148061)
  Reland Native ios context menu (flutter#143002) (flutter#148238) (flutter#148265)
  Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter#148419)
  Stop running module_test_ios in devicelab and x64 Macs (flutter#148264)
  Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter#148369)
  Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter#148367)
  Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter#148365)
  ...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2024
@engine-flutter-autoroll
b1677f6 Reland fix TextField helper top padding on M3 (flutter/flutte…
d5c7c50 
…r#146754)
@bleroux bleroux deleted the reland_fix_textfield_helper_top_padding_on_M3 branch May 16, 2024 15:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2024
@engine-flutter-autoroll
b1677f6 Reland fix TextField helper top padding on M3 (flutter/flutte…
35b5fcf 
…r#146754)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 16, 2024
@engine-flutter-autoroll
Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (#6748)
7d0f88f 
flutter/flutter@39651e8...0d22d91

2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816)
2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476)
2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469)
2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465)
2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408)
2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403)
2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378)
2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455)
2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754)
2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281)
2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450)
2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448)
2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445)
2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441)
2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434)
2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430)
2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428)
2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool>  to indicate whether any of the observer has handled the route or not (flutter/flutter#147901)
2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373)
2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061)
2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265)
2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419)
2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (flutter#6748)
c15efcf 
flutter/flutter@39651e8...0d22d91

2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816)
2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476)
2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469)
2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465)
2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408)
2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403)
2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378)
2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455)
2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754)
2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281)
2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450)
2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448)
2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445)
2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441)
2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434)
2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430)
2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428)
2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool>  to indicate whether any of the observer has handled the route or not (flutter/flutter#147901)
2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373)
2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061)
2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265)
2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419)
2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bleroux bleroux mentioned this pull request Jul 12, 2024
Merged
auto-submit bot pushed a commit that referenced this pull request Jul 12, 2024
@bleroux
Update obsolete comment in InputDecorator test (#151651)
bf6c455 
Update one comment which is obsolete since #146754
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
b1677f6 Reland fix TextField helper top padding on M3 (flutter/flutte…
f87466d 
…r#146754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@Renzo-Olivares Renzo-Olivares Awaiting requested review from Renzo-Olivares

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextField helper text top padding should be 4.0 on Material3
2 participants
@bleroux @justinmc