Skip to content

Commit e75b224

Browse files
Merge branch 'master' into fix/gridview_delegate
* master: (2580 commits) plugin_ffi template comment fix (flutter#148378) Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter#148455) Reland fix TextField helper top padding on M3 (flutter#146754) Removing duplicate assert on `VisualDensity` constructor (flutter#148281) Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter#148450) Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter#148448) Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter#148445) Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter#148441) Fix leaky tests. (flutter#148434) Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter#148430) Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter#148428) Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter#147901) Fix memory leaks in `_PopupMenuRoute` (flutter#148373) Add `clipBehavior` to `DrawerThemeData` (flutter#148061) Reland Native ios context menu (flutter#143002) (flutter#148238) (flutter#148265) Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter#148419) Stop running module_test_ios in devicelab and x64 Macs (flutter#148264) Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter#148369) Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter#148367) Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter#148365) ...
2 parents 2b7a8e3 + 8a4179e commit e75b224

File tree

3,350 files changed

+198919
-65819
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

3,350 files changed

+198919
-65819
lines changed

.ci.yaml

Lines changed: 1034 additions & 495 deletions
Large diffs are not rendered by default.

.github/ISSUE_TEMPLATE/1_activation.yml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,12 @@ body:
1717
1818
If you have found a bug or if our documentation doesn't have an answer
1919
to what you're looking for, then fill out the template below.
20-
- type: checkboxes
20+
- type: markdown
2121
attributes:
22-
label: Is there an existing issue for this?
23-
description: Please search to see if an issue already exists for the bug you encountered.
24-
options:
25-
- label: I have searched the [existing issues](https://github.com/flutter/flutter/issues)
26-
required: true
27-
- label: I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
28-
required: true
22+
value: |
23+
Before filling the form fields, please consider the following:
24+
- Ensure that you have searched the [existing issues](https://github.com/flutter/flutter/issues)
25+
- Read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
2926
- type: textarea
3027
attributes:
3128
label: Steps to reproduce
@@ -58,7 +55,7 @@ body:
5855
Note: Please do not upload screenshots of text. Instead, use code blocks
5956
or the above mentioned ways to upload logs.
6057
value: |
61-
<details>
58+
<details open>
6259
<summary>Logs</summary>
6360
6461
```console
@@ -74,7 +71,7 @@ body:
7471
description: |
7572
Please provide the full output of running `flutter doctor -v`
7673
value: |
77-
<details>
74+
<details open>
7875
<summary>Doctor output</summary>
7976
8077
```console

.github/ISSUE_TEMPLATE/2_bug.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@ body:
1414
- https://flutter.dev/
1515
- https://api.flutter.dev/
1616
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent
17-
- type: checkboxes
17+
- type: markdown
1818
attributes:
19-
label: Is there an existing issue for this?
20-
options:
21-
- label: I have searched the [existing issues](https://github.com/flutter/flutter/issues)
22-
required: true
23-
- label: I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
24-
required: true
19+
value: |
20+
Before filling the form fields, please consider the following:
21+
- Ensure that you have searched the [existing issues](https://github.com/flutter/flutter/issues)
22+
- Read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
2523
- type: textarea
2624
attributes:
2725
label: Steps to reproduce
@@ -62,7 +60,7 @@ body:
6260
Note: Please do not upload screenshots of text. Instead, use code blocks
6361
or the above mentioned ways to upload your code sample.
6462
value: |
65-
<details><summary>Code sample</summary>
63+
<details open><summary>Code sample</summary>
6664
6765
```dart
6866
[Paste your code here]
@@ -77,7 +75,7 @@ body:
7775
description: |
7876
Upload any screenshots or video of the bug if applicable.
7977
value: |
80-
<details>
78+
<details open>
8179
<summary>Screenshots / Video demonstration</summary>
8280
8381
[Upload media here]
@@ -99,7 +97,7 @@ body:
9997
Note: Please do not upload screenshots of text. Instead, use code blocks
10098
or the above mentioned ways to upload logs.
10199
value: |
102-
<details><summary>Logs</summary>
100+
<details open><summary>Logs</summary>
103101
104102
```console
105103
[Paste your logs here]
@@ -112,7 +110,7 @@ body:
112110
description: |
113111
Please provide the full output of running `flutter doctor -v`
114112
value: |
115-
<details><summary>Doctor output</summary>
113+
<details open><summary>Doctor output</summary>
116114
117115
```console
118116
[Paste your output here]

.github/ISSUE_TEMPLATE/3_feature_request.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,12 @@ body:
1212
- https://flutter.dev/
1313
- https://api.flutter.dev/
1414
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent
15-
- type: checkboxes
15+
- type: markdown
1616
attributes:
17-
label: Is there an existing issue for this?
18-
description: Please search to see if an issue already exists for this feature request or proposal.
19-
options:
20-
- label: I have searched the [existing issues](https://github.com/flutter/flutter/issues)
21-
required: true
22-
- label: I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
23-
required: true
17+
value: |
18+
Before filling the form fields, please consider the following:
19+
- Ensure that you have searched the [existing issues](https://github.com/flutter/flutter/issues)
20+
- Read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
2421
- type: textarea
2522
attributes:
2623
label: Use case

.github/ISSUE_TEMPLATE/4_performance_others.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ body:
3939
4040
Note: Please do not upload screenshots of text. Instead, use code blocks or the above mentioned ways to upload your code sample.
4141
value: |
42-
<details><summary>Code sample</summary>
42+
<details open><summary>Code sample</summary>
4343
4444
```dart
4545
[Paste your code here]
@@ -90,7 +90,7 @@ body:
9090
9191
Note: Please do not upload screenshots of text. Instead, use code blocks or the above mentioned ways to upload logs.
9292
value: |
93-
<details><summary>Logs</summary>
93+
<details open><summary>Logs</summary>
9494
9595
```console
9696
[Paste your logs here]
@@ -103,7 +103,7 @@ body:
103103
description: |
104104
Finally, paste the output of running `flutter doctor -v` here, with your device plugged in.
105105
value: |
106-
<details><summary>Doctor output</summary>
106+
<details open><summary>Doctor output</summary>
107107
108108
```console
109109
[Paste your output here]

.github/ISSUE_TEMPLATE/5_performance_speed.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ body:
3939
4040
Note: Please do not upload screenshots of text. Instead, use code blocks or the above mentioned ways to upload your code sample.
4141
value: |
42-
<details><summary>Code sample</summary>
42+
<details open><summary>Code sample</summary>
4343
4444
```dart
4545
[Paste your code here]
@@ -71,7 +71,7 @@ body:
7171
7272
If the trace are too large to be uploaded to GitHub, you may upload them as a `zip` file or use online tools like https://pastebin.com to share it.
7373
value: |
74-
<details><summary>Timeline Traces JSON</summary>
74+
<details open><summary>Timeline Traces JSON</summary>
7575
7676
```json
7777
[Paste the Timeline Traces here]
@@ -88,7 +88,7 @@ body:
8888
8989
Don’t use "adb screenrecord", as that affects the performance of the profile run.
9090
value: |
91-
<details>
91+
<details open>
9292
<summary>Video demonstration</summary>
9393
9494
[Upload media here]
@@ -148,7 +148,7 @@ body:
148148
149149
Note: Please do not upload screenshots of text. Instead, use code blocks or the above mentioned ways to upload logs.
150150
value: |
151-
<details><summary>Logs</summary>
151+
<details open><summary>Logs</summary>
152152
153153
```console
154154
[Paste your logs here]
@@ -161,7 +161,7 @@ body:
161161
description: |
162162
Finally, paste the output of running `flutter doctor -v` here, with your device plugged in.
163163
value: |
164-
<details><summary>Doctor output</summary>
164+
<details open><summary>Doctor output</summary>
165165
166166
```console
167167
[Paste your output here]

.github/ISSUE_TEMPLATE/6_infrastructure.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,10 @@ body:
1313
It looks like you found an issue with our Infrastructure services.
1414
Please complete the form below so that we can help to resolve your
1515
issue as quickly as possible.
16-
- type: checkboxes
16+
- type: markdown
1717
attributes:
18-
label: Is there an existing issue for this?
19-
options:
20-
- label: I have searched the [existing infra issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Ateam-infra)
21-
required: true
18+
value: |
19+
Before filling the form fields, please ensure that you have searched the [existing infra issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Ateam-infra)
2220
- type: dropdown
2321
attributes:
2422
label: Type of Request

.github/ISSUE_TEMPLATE/7_cherry_pick.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,16 @@ description: As a contributor, you would like to request that a feature be cherr
33
title: '[CP] <title>'
44
labels: ['cp: review']
55
body:
6+
- type: markdown
7+
attributes:
8+
value: "### The current branches can be found under release-candidate-branch.version for [beta](https://github.com/flutter/flutter/blob/beta/bin/internal/release-candidate-branch.version) and [stable](https://github.com/flutter/flutter/blob/stable/bin/internal/release-candidate-branch.version)"
69
- type: input
710
id: issue_link
811
attributes:
912
label: Issue Link
1013
description: What is the link to the issue this cherry-pick is addressing?
1114
validations:
1215
required: true
13-
- type: input
14-
id: commit_hash
15-
attributes:
16-
label: Commit Hash
17-
description: What is the shortened commit hash that has been merged to master/main?
18-
validations:
19-
required: true
2016
- type: dropdown
2117
id: Target
2218
attributes:
@@ -33,15 +29,15 @@ body:
3329
label: PR Link
3430
description: >-
3531
Link to an open PR that cherrypick's this into the target release branch.
36-
The current branches can be found under release-caniddate-branch.version for [beta](https://github.com/flutter/flutter/blob/beta/bin/internal/release-candidate-branch.version) and [stable](https://github.com/flutter/flutter/blob/stable/bin/internal/release-candidate-branch.version)
32+
The current branches can be found under release-candidate-branch.version for [beta](https://github.com/flutter/flutter/blob/beta/bin/internal/release-candidate-branch.version) and [stable](https://github.com/flutter/flutter/blob/stable/bin/internal/release-candidate-branch.version)
3733
validations:
3834
required: true
3935
- type: textarea
4036
id: changelog_description
4137
attributes:
4238
label: Changelog Description
4339
description: >-
44-
Explain this CP in one line that is accessible to most Flutter developers
40+
Explain this CP in less than 80 characters that is accessible to most Flutter developers
4541
See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples
4642
validations:
4743
required: true

.github/ISSUE_TEMPLATE/9_first_party_packages.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,12 @@ body:
1313
- https://flutter.dev/
1414
- https://api.flutter.dev/
1515
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent
16-
- type: checkboxes
16+
- type: markdown
1717
attributes:
18-
label: Is there an existing issue for this?
19-
options:
20-
- label: I have searched the [existing package issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Apackage)
21-
required: true
22-
- label: I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
23-
required: true
18+
value: |
19+
Before filling the form fields, please consider the following:
20+
- Ensure that you have searched the [existing package issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Apackage)
21+
- Read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
2422
- type: dropdown
2523
id: packages
2624
attributes:
@@ -164,7 +162,7 @@ body:
164162
Note: Please do not upload screenshots of text. Instead, use code blocks
165163
or the above mentioned ways to upload your code sample.
166164
value: |
167-
<details><summary>Code sample</summary>
165+
<details open><summary>Code sample</summary>
168166
169167
```dart
170168
[Paste your code here]
@@ -179,7 +177,7 @@ body:
179177
description: |
180178
Upload any screenshots or videos of the bug if applicable.
181179
value: |
182-
<details>
180+
<details open>
183181
<summary>Screenshots / Video demonstration</summary>
184182
185183
[Upload media here]
@@ -201,7 +199,7 @@ body:
201199
Note: Please do not upload screenshots of text. Instead, use code blocks
202200
or the above mentioned ways to upload logs.
203201
value: |
204-
<details><summary>Logs</summary>
202+
<details open><summary>Logs</summary>
205203
206204
```console
207205
[Paste your logs here]
@@ -214,7 +212,7 @@ body:
214212
description: |
215213
Please provide the full output of running `flutter doctor -v`
216214
value: |
217-
<details><summary>Doctor output</summary>
215+
<details open><summary>Doctor output</summary>
218216
219217
```console
220218
[Paste your output here]
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request)
2+
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
3+
4+
### Issue Link:
5+
What is the link to the issue this cherry-pick is addressing?
6+
7+
< Replace with issue link here >
8+
9+
### Changelog Description:
10+
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices) for examples
11+
12+
< Replace with changelog description here >
13+
14+
### Impact Description:
15+
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
16+
17+
< Replace with impact description here >
18+
19+
### Workaround:
20+
Is there a workaround for this issue?
21+
22+
< Replace with workaround here >
23+
24+
### Risk:
25+
What is the risk level of this cherry-pick?
26+
27+
- [ ] Low
28+
- [ ] Medium
29+
- [ ] High
30+
31+
### Test Coverage:
32+
Are you confident that your fix is well-tested by automated tests?
33+
34+
- [ ] Yes
35+
- [ ] No
36+
37+
### Validation Steps:
38+
What are the steps to validate that this fix works?
39+
40+
< Replace with validation steps here >

0 commit comments

Comments
 (0)