Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@harryterkelsen
Copy link
Contributor

Fixes flutter/flutter#73628
Fixes flutter/flutter#76182

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 9ac72f8 into flutter:master Feb 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
christopherfujino added a commit that referenced this pull request Feb 23, 2021
…24557)

* Update Dart to 2.12.0-259.15.beta

* Propagate image decode errors to the future returned by Codec.getNextFrame (#24336)

* fix infinite loop in findMinimumFontsForCodeunits (#24441)

* Roll CanvasKit to 0.24. (#24498)

* Update tests for new API

* Update goldens and respond to comment

* fix missing CJK and symbol glyphs, font precedence, fallback reset (#24470)

* fix missing CJK and symbol glyphs
* Cache known covered code units

Co-authored-by: Harry Terkelsen <[email protected]>

* Update licenses_golden

Co-authored-by: Jason Simmons <[email protected]>
Co-authored-by: Yegor <[email protected]>
Co-authored-by: Harry Terkelsen <[email protected]>
Co-authored-by: Harry Terkelsen <[email protected]>
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
* Update tests for new API

* Update goldens and respond to comment
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
* Update tests for new API

* Update goldens and respond to comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

3 participants