Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fix infinite loop in findMinimumFontsForCodeunits #24441

Merged
yjbanov merged 1 commit into from
Feb 16, 2021
Merged

fix infinite loop in findMinimumFontsForCodeunits #24441

yjbanov merged 1 commit into from
Feb 16, 2021

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Feb 16, 2021

Reset the maxCodeunitsCovered and bestFonts variables inside the while loop. Otherwise they leak previous for loop's state to subsequent loops.

Fixes flutter/flutter#75836

harryterkelsen
harryterkelsen approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov merged commit bcd8c71 into flutter:master Feb 16, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
a4f5649 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
01b8ab0 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
f4583f5 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
2f8c443 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
1b3689b 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
7497381 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
01efbda 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
5208eda 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
a87322b 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
873d7cf 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
b3ecd53 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
8e5c8b7 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
bcb910c 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
812d97b 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
abb7bec 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
a6c6c9b 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
742fe52 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
ab4cd41 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
3c4c78e 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
2470f38 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
5031438 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
59239ae 
…gine#24441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
19ef978 
…gine#24441)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
9be1542 
…gine#24441)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
1a3c196 
…gine#24441)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
3ce9e93 
…gine#24441)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
203b538 
…gine#24441)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
5999b7a 
…gine#24441)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
bcd8c71 fix infinite loop in findMinimumFontsForCodeunits (flutter/en…
0a42a16 
…gine#24441)
christopherfujino added a commit that referenced this pull request Feb 23, 2021
@christopherfujino @jason-simmons
@yjbanov @harryterkelsen
[flutter_releases] Flutter 1.26.0-17.7.pre Beta Engine Cherrypicks (#…
4a466e1 
…24557)

* Update Dart to 2.12.0-259.15.beta

* Propagate image decode errors to the future returned by Codec.getNextFrame (#24336)

* fix infinite loop in findMinimumFontsForCodeunits (#24441)

* Roll CanvasKit to 0.24. (#24498)

* Update tests for new API

* Update goldens and respond to comment

* fix missing CJK and symbol glyphs, font precedence, fallback reset (#24470)

* fix missing CJK and symbol glyphs
* Cache known covered code units

Co-authored-by: Harry Terkelsen <[email protected]>

* Update licenses_golden

Co-authored-by: Jason Simmons <[email protected]>
Co-authored-by: Yegor <[email protected]>
Co-authored-by: Harry Terkelsen <[email protected]>
Co-authored-by: Harry Terkelsen <[email protected]>
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@yjbanov @hjfreyer
fix infinite loop in findMinimumFontsForCodeunits (flutter#24441)
31fdb90
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Web] Pasting multiple non-eurpoean unicode characters into TextField drives CPU to 100% and freezes tab

3 participants

@yjbanov @harryterkelsen @googlebot