This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Propagate image decode errors to the future returned by Codec.getNextFrame #24336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
force-pushed
the
bug_75560
branch
from
858899e to
26fc663
Compare
chinmaygarde
approved these changes
Feb 10, 2021
jason-simmons
force-pushed
the
bug_75560
branch
from
26fc663 to
7e9cb22
Compare
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 12, 2021
christopherfujino
added a commit
that referenced
this pull request
Feb 23, 2021
…24557) * Update Dart to 2.12.0-259.15.beta * Propagate image decode errors to the future returned by Codec.getNextFrame (#24336) * fix infinite loop in findMinimumFontsForCodeunits (#24441) * Roll CanvasKit to 0.24. (#24498) * Update tests for new API * Update goldens and respond to comment * fix missing CJK and symbol glyphs, font precedence, fallback reset (#24470) * fix missing CJK and symbol glyphs * Cache known covered code units Co-authored-by: Harry Terkelsen <[email protected]> * Update licenses_golden Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]>
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#75560