Fix root tests to be ran as isolated tests #289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix the snapshotter root tests were not being run. This change changes the root tests to be isolated tests and which allows them to be ran in our CI pipeline. Signed-off-by: xibz <[email protected]>
Contributor
Author
|
Closing as it looks like the root tests are actually ran. See in buildkite under |
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
Remove root-owned files
BenjaminChun
pushed a commit
to char-1ee/firecracker-containerd
that referenced
this pull request
Apr 25, 2024
includes firecracker-microvm#289, firecracker-microvm#317, firecracker-microvm#328, firecracker-microvm#329, firecracker-microvm#330, firecracker-microvm#332 Signed-off-by: Bora M. Alper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix the snapshotter root tests were not being run. This
change changes the root tests to be isolated tests and which allows them
to be ran in our CI pipeline.
Signed-off-by: xibz [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.