-
Notifications
You must be signed in to change notification settings - Fork 200
Modify getting-started to use devmapper snapshottter #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should mention that this kind of configuration is slow, should be avoided in production and suitable only for local testing. https://docs.docker.com/storage/storagedriver/device-mapper-driver/#performance-best-practices |
Do you think a |
containerd 1.3 is already having the devmapper snapshotter. Don't we want to use the upstream one instead of our plugin one? |
May be something like:
Yeah. We should start this transition. But I don't think it has be done here as this PR focuses on thin-pool creation. I've created an issue to track: #318 |
Signed-off-by: Cody Roseborough <[email protected]>
6563b73
to
b0d55d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Royce Zhao <[email protected]>
includes firecracker-microvm#289, firecracker-microvm#317, firecracker-microvm#328, firecracker-microvm#329, firecracker-microvm#330, firecracker-microvm#332 Signed-off-by: Bora M. Alper <[email protected]>
Signed-off-by: Cody Roseborough [email protected]
Issue #, if available: #194
Description of changes:
Modifies the getting started guide to use dev-mapper snapshotter instead of the naive snapshotter.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.