Skip to content

Modify getting-started to use devmapper snapshottter #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

IRCody
Copy link
Contributor

@IRCody IRCody commented Oct 31, 2019

Signed-off-by: Cody Roseborough [email protected]

Issue #, if available: #194

Description of changes:
Modifies the getting started guide to use dev-mapper snapshotter instead of the naive snapshotter.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mxpv
Copy link
Contributor

mxpv commented Oct 31, 2019

We should mention that this kind of configuration is slow, should be avoided in production and suitable only for local testing. https://docs.docker.com/storage/storagedriver/device-mapper-driver/#performance-best-practices

@IRCody
Copy link
Contributor Author

IRCody commented Oct 31, 2019

We should mention that this kind of configuration is slow, should be avoided in production and suitable only for local testing. https://docs.docker.com/storage/storagedriver/device-mapper-driver/#performance-best-practices

Do you think a Note: This is not a production ready configuration, see link is enough or do you think it might be worth saying more?

@kzys
Copy link
Contributor

kzys commented Oct 31, 2019

containerd 1.3 is already having the devmapper snapshotter. Don't we want to use the upstream one instead of our plugin one?

@mxpv
Copy link
Contributor

mxpv commented Oct 31, 2019

Do you think a Note: This is not a production ready configuration, see link is enough or do you think it might be worth saying more?

May be something like: Note: the configuration with loopback devices is slow and not intended for use in production ?

containerd 1.3 is already having the devmapper snapshotter. Don't we want to use the upstream one instead of our plugin one?

Yeah. We should start this transition. But I don't think it has be done here as this PR focuses on thin-pool creation. I've created an issue to track: #318

Copy link
Contributor

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IRCody IRCody merged commit 3f8a4b0 into firecracker-microvm:master Nov 5, 2019
@mxpv mxpv mentioned this pull request Dec 12, 2019
5 tasks
fangn2 pushed a commit to fangn2/firecracker-containerd that referenced this pull request Mar 23, 2023
BenjaminChun pushed a commit to char-1ee/firecracker-containerd that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants