Run "make test" on Travis CI #330
Conversation
|
While you're in here, it's probably worth fixing the |
|
Good catch on that test using that new API, I really, really wish the go docs made any effort to say that a given api was introduced in a particular version (let me know if there's some way I'm not aware of).... But that is what it is. I can submit a separate PR to check the exit code the old way so we don't have a 1.12 requirement. For the travis build, we already run the unit tests in buildkite, so I'm wondering if all we should do in travis is If that doesn't work it's not the end of the world to just run the unit tests in travis too though. |
|
Well, they have "1.12" on the right :) https://golang.org/pkg/os/#ProcessState.ExitCode Actually I would rather just drop Go 1.11 support. Firecracker Go SDK may need to support older versions, but firecracker-containerd doesn't have to, I think. |
Haha! My widescreen monitor is so widescreen I have to turn my neck to look at the right side. Good to know though, thanks! |
Given the fix to this issue is very straightforward, I feel like we may as well not drop go 1.11 if we don't have to. Debian buster, for example, is still on go 1.11 by default afaik, so it might make it easier for some users to build if we don't require 1.12+ |
|
You are right. Debian... https://packages.debian.org/buster/golang Will update the test in this PR then. |
kzys
force-pushed
the
travis-build
branch
3 times, most recently
from
3db2a8b to
5e31220
Compare
"make" doesn't compile *_test.go, but "make test" does. 121afa3 introduced ProcessState.ExitCode which is not available in Go 1.11. Signed-off-by: Kazuyoshi Kato <[email protected]>
The default timeout is 1m, and we are constantly exceeding Signed-off-by: Kazuyoshi Kato <[email protected]>
But we still want to support Go 1.11. Signed-off-by: Kazuyoshi Kato <[email protected]>
The exit code is in MSB. Not so sure why it was working on firecracker-microvm#330 itself's BuildKite check though. Signed-off-by: Kazuyoshi Kato <[email protected]>
…ependabot/go_modules/github.com/sirupsen/logrus-1.8.1 Bump github.com/sirupsen/logrus from 1.8.0 to 1.8.1
includes firecracker-microvm#289, firecracker-microvm#317, firecracker-microvm#328, firecracker-microvm#329, firecracker-microvm#330, firecracker-microvm#332 Signed-off-by: Bora M. Alper <[email protected]>
"make" doesn't compile *_test.go, but "make test" does.
121afa3 introduced
ProcessState.ExitCode which is not available in Go 1.11.
Signed-off-by: Kazuyoshi Kato [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.