-
Notifications
You must be signed in to change notification settings - Fork 122
Add architectures to desktop integration test matrix, and enable arm64/x86 tests. #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit 1d1bba1
Add flaky tests to go/fpl-cpp-flake-tracker |
3 tasks
cynthiajoan
reviewed
May 9, 2022
cynthiajoan
approved these changes
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add arch to the build_desktop matrix, and add architecture tags to all of the artifact names etc.
This allows us to:
This PR includes all of the above. And look, it reveals some bugs! e.g. an x86 issue in RTDB (fixed in #939)
Testing
Full integration test run on this PR.
Integration test on packaged SDK here.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.