Skip to content

Add architectures to desktop integration test matrix, and enable arm64/x86 tests. #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 101 commits into from
May 10, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 6, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Add arch to the build_desktop matrix, and add architecture tags to all of the artifact names etc.

This allows us to:

  • Actually use the architecture_* fields in print_matrix_configuration.py
  • Enable arm64 Mac tests on our M1 Mac GitHub custom runner (when testing on the expanded matrix).
  • Enable x86 Linux/Windows tests (when testing on the expanded matrix).
    • For Linux, this required moving the x86 runner setup to a shared module and add customization options to the install prereqs script.

This PR includes all of the above. And look, it reveals some bugs! e.g. an x86 issue in RTDB (fixed in #939)


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Full integration test run on this PR.
Integration test on packaged SDK here.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

Add custom runner for arm64 mac support.

Enable x86 Linux/Windows tests.
@jonsimantov jonsimantov changed the title Add architecture to desktop integration test matrix Experimental: Add architecture to desktop integration test matrix May 6, 2022
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 6, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 6, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 1d1bba1
Last updated: Tue May 10 00:18 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/2 os: macos] [android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 6, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 6, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@jonsimantov jonsimantov removed the request for review from cynthiajoan May 9, 2022 19:36
@jonsimantov jonsimantov marked this pull request as draft May 9, 2022 19:36
@jonsimantov jonsimantov requested a review from cynthiajoan May 9, 2022 22:15
@jonsimantov jonsimantov marked this pull request as ready for review May 9, 2022 22:15
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 9, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 9, 2022
@jonsimantov jonsimantov merged commit 1d1bba1 into main May 10, 2022
@jonsimantov jonsimantov deleted the feature/integration_test_arch branch May 10, 2022 03:25
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 10, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 10, 2022
@firebase firebase locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants