Skip to content

Move x86 Linux setup to prereqs script #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 9, 2022
Merged

Move x86 Linux setup to prereqs script #945

merged 11 commits into from
May 9, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 9, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Move x86 Linux setup to prereqs - this lets us add a retry to the Linux package installation, which can sometimes fail due to network connectivity.

(The setup is still present in the build script, but won't do anything if it determines that the required packages are installed.)

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Desktop checks and integration tests in this PR.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label May 9, 2022
@jonsimantov jonsimantov requested a review from a-maurice May 9, 2022 19:01
dconeybe
dconeybe reviewed May 9, 2022
View reviewed changes
@jonsimantov jonsimantov changed the title Move x86 Linux setup to prereqs Move x86 Linux setup to prereqs script May 9, 2022
dconeybe
dconeybe reviewed May 9, 2022
View reviewed changes
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

⏳  Integration test in progress...

Requested by @jonsimantov on commit 792395e
Last updated: Mon May 9 15:08 PDT 2022
View integration test log & download artifacts

@jonsimantov jonsimantov requested a review from a-maurice May 9, 2022 19:26
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 9, 2022
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label May 9, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 9, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 9, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) May 9, 2022 19:58
@jonsimantov jonsimantov merged commit 792395e into main May 9, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels May 9, 2022
@jonsimantov jonsimantov mentioned this pull request May 9, 2022
Merged
3 tasks
@jonsimantov jonsimantov deleted the other/move-x86-setup-to-prereqs branch May 9, 2022 22:19
@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe left review comments

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels
skip-release-notes Skip release notes check tests: in-progress This PR's integration tests are in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonsimantov @a-maurice @dconeybe