Fix local server timestamp handling on 32-bit architectures #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
a-maurice
approved these changes
May 9, 2022
github-actions
bot
added
the
tests: in-progress
⏳ Integration test in progress...Requested by @jonsimantov on commit 817de86 |
jonsimantov
removed
the
tests: in-progress
jonsimantov
added a commit
that referenced
this pull request
May 10, 2022
…4/x86 tests. (#931) Add *arch* to the build_desktop matrix, and add architecture tags to all of the artifact names etc. This allows us to: - Actually use the architecture_\* fields in print_matrix_configuration.py - Enable arm64 Mac tests on our M1 Mac GitHub custom runner (when testing on the expanded matrix). - Enable x86 Linux/Windows tests (when testing on the expanded matrix). - For Linux, this required moving the x86 runner setup to a shared module and add customization options to the install prereqs script. This PR includes all of the above. And look, it reveals some bugs! e.g. an x86 issue in RTDB (fixed in #939)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On 32-bit Linux, time() returns a 32-bit integer. Cast it to 64-bit before doing math on it. This fixes a bug in the RTDB integration tests on x86 devices.
Testing
Tested in #931.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.