Bugfix/app cmake exceptions private #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
reviewed
Jul 21, 2021
app/tests/thread_test.cc
Outdated
| @@ -20,6 +20,17 @@ | |||
| #include "gmock/gmock.h" | |||
| #include "gtest/gtest.h" | |||
|
|
|||
| #define EXPECT_SYSTEM_ERROR(statement, error_code) \ | |||
There was a problem hiding this comment.
WDYT about naming this something like EXPECT_THROW_WITH_CODE? (just a thought - so it's clearer in the tests that this is specifically testing for a thrown exception.) Or if you think it isn't too wordy, just to use EXPECT_THROW directly with the EXPECT_EQ inside the catch in each of the tests, rather than the #define, since it's all just in this file anyway.
There was a problem hiding this comment.
Ah good point. I wanted to avoid repeating the pattern (EXPECT_THROW with EXPECT_EQ) in multiple places. I could change it to that but it seemed like a lot of code duplication. How about EXPECT_THROW_WITH_ERROR_CODE?
DellaBitta
previously approved these changes
Jul 22, 2021
vimanyu
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @vimanyu on commit 984f698
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
vimanyu
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
vimanyu
added
tests-requested: full
github-actions
bot
removed
the
tests-requested: full
vimanyu
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
vimanyu
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
reviewed
Jul 27, 2021
jonsimantov
approved these changes
Jul 27, 2021
vimanyu
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
the
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the "no exceptions" compiler setting for Firebase app a private dependency so it does not affect the consuming projects.
Some of the unit tests dealing with threads now throw an exception and have been modified to expect such exceptions.