Firebase SDK enforces -fno-exceptions for whole project

[dingari]

[REQUIRED] Please fill in the following fields:

• Pre-built SDK from the website or open-source from this repo: open-source
• Firebase C++ SDK version: 6.16.0 (latest at the time of writing)
• Problematic Firebase Component: firebase cmake script
• Other Firebase Components in use: auth
• Platform you are using the C++ SDK on: Mac
• Platform you are targeting: desktop

[REQUIRED] Please describe the issue here:

I'm working on integrating the Firebase C++ SDK into an existing CMake project, just adding it via cmake_add_subdirectory

set(OPENSSL_ROOT_DIR /usr/local/opt/openssl)
set(OPENSSL_LIBRARIES /usr/local/opt/openssl/lib)
set(BUILD_TESTING OFF)
set(FIREBASE_INCLUDE_DATABASE OFF)
set(FIREBASE_INCLUDE_FIRESTORE OFF)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../../firebase ${CMAKE_CURRENT_BINARY_DIR}/firebase)

and

target_link_libraries(${TARGET} PRIVATE firebase_analytics firebase_app)

Building my target fails due to exceptions being disabled for firebase-app. My project depends on other libraries that are using exceptional C++ code. I think these lines in firebase/app/CMakeLists.txt shouldn't be using the PUBLIC attribute

# Disable exceptions in std
if (MSVC)
  target_compile_options(firebase_app PUBLIC /EHs-c-)
else()
  target_compile_options(firebase_app PUBLIC -fno-exceptions)
endif()

Changing these manually to PRIVATE allows me to compile and link just fine. Is there a reason for these being set to PUBLIC?

Steps to reproduce:

Adding the SDK to a project with exceptional C++ code will make it fail 100% of the time.

If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.

Relevant Code:

See description

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[vimanyu]

Thanks for bringing this up and the suggestion to use PRIVATE instead of PUBLIC. Am following up with the team and will update if this can be done.

[vimanyu]

Just an update, we are testing if making this dependency Private will affect building and packaging other products as many of them depend on app.

[furyu-araki]

I have workaround to rewrite exceptions option.
add below to parent CMakeLists.txt:

target_compile_options(firebase_app PUBLIC -fexceptions)

[mikepulaski]

@vimanyu Any update on this? I’m running into the same issue, but would like to understand the implications of overriding this a little more. Thanks!

cc @alexames

[vimanyu]

Hi, sorry for not pushing this out earlier and at the time, we were working on migrating our test suite to github. I don't think there should be any side effects of doing this but just to be sure, I am going to test this out on our suite of unit and integration tests, and hopefully push it out in the next release.