Skip to content

Bugfix/app cmake exceptions private #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 27, 2021
Merged

Bugfix/app cmake exceptions private #561

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ceb99d0
changing compiler option for exceptions to private
vimanyu Jul 14, 2021
beca0cb
fix unit tests now that exceptions are enabled.
vimanyu Jul 20, 2021
c3db71c
using a better name for macro
vimanyu Jul 21, 2021
c926d5b
using old cmake on windows builds
vimanyu Jul 22, 2021
6472606
Merge branch 'main' into bugfix/app-cmake-exceptions-private
vimanyu Jul 22, 2021
a1959de
no exceptions compiler settings on app updated
vimanyu Jul 22, 2021
6352a70
no need to pin cmake version
vimanyu Jul 22, 2021
76dfd77
Merge branch 'main' into bugfix/app-cmake-exceptions-private
vimanyu Jul 26, 2021
9b657b8
fixed formatting
vimanyu Jul 26, 2021
d470b84
Merge branch 'main' into bugfix/app-cmake-exceptions-private
vimanyu Jul 27, 2021
7e9e4b3
reordered release notes
vimanyu Jul 27, 2021
c95c5cf
fixed release notes
vimanyu Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,13 +575,13 @@ code.
iOS and tvOS. The following products are currently included for tvOS:
Auth, Database, Firestore, Functions, Installations, Messaging,
Remote Config, Storage.
- General: Compiler setting of "no exceptions" on app is PRIVATE now
and will not affect other targets in CMake builds.
- Firestore: Removed the deprecated
`Firestore::RunTransaction(TransactionFunction*)` function. Please use
the overload that takes a `std::function` argument instead.
- Firestore: `FieldValue::Increment` functions are no longer guarded by
the `INTERNAL_EXPERIMENTAL` macro.
- General: Compiler setting of "no exceptions" on app is PRIVATE now
and will not affect other targets in CMake builds.
- Firestore: added more validation of invalid input.
- Firestore: added an `is_valid` method to the public API classes that can
be in an invalid state.
Expand Down