Skip to content

Temporarily remove NamedQuery from the public API #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2021
Merged

Temporarily remove NamedQuery from the public API #452

merged 3 commits into from
Jun 9, 2021

Conversation

var-const
Copy link
Contributor

See b/190545340.

@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 9, 2021
@var-const var-const requested a review from a-maurice June 9, 2021 00:23
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Jun 9, 2021
@github-actions github-actions bot removed the tests: failed This PR's integration tests failed. label Jun 9, 2021
@github-actions
Copy link

github-actions bot commented Jun 9, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @var-const on commit bc817e6
Last updated: Tue Jun 8 22:15:41 PDT 2021
Download integration test detailed logs and artifacts

Failures Configs
firestore [TEST] [FAILURE] [MacOS] [boringssl]
(1 failed tests)  LoadInvalidBundlesShouldFail

jonsimantov
jonsimantov approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming tests pass.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 9, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 9, 2021
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Jun 9, 2021
@jonsimantov
Copy link
Contributor

Failed test looks like just a timeout - untagging.

@var-const var-const enabled auto-merge (squash) June 9, 2021 17:47
@var-const var-const merged commit 8598f29 into firebase:main Jun 9, 2021
wu-hui added a commit that referenced this pull request Jun 15, 2021
@wu-hui
Revert "Temporarily remove NamedQuery from the public API (#452)"
1886d20 
This reverts commit 8598f29.
wu-hui added a commit that referenced this pull request Jun 24, 2021
@wu-hui
Revert "Temporarily remove NamedQuery from the public API (#452)"
7777627 
This reverts commit 8598f29
wu-hui added a commit that referenced this pull request Jun 24, 2021
@wu-hui
Revert "Temporarily remove NamedQuery from the public API (#452)"
1d44ef9 
This reverts commit 8598f29
wu-hui added a commit that referenced this pull request Jun 29, 2021
@wu-hui
Fix absl leakage by using Firebase 8.2.0 (#491)
090eb4d 
* Revert "Temporarily remove `NamedQuery` from the public API (#452)"

This reverts commit 8598f29

* Change to use absl-free interface.

* Change pod to 8.2.0

* Reformat

* Add release entry

* Reword

* Check in pbxproj changes
jonsimantov pushed a commit that referenced this pull request Jul 1, 2021
@wu-hui @jonsimantov
Fix absl leakage by using Firebase 8.2.0 (#491)
63e56c2 
* Revert "Temporarily remove `NamedQuery` from the public API (#452)"

This reverts commit 8598f29

* Change to use absl-free interface.

* Change pod to 8.2.0

* Reformat

* Add release entry

* Reword

* Check in pbxproj changes
@firebase firebase locked and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

@a-maurice a-maurice Awaiting requested review from a-maurice

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@var-const @jonsimantov