Fix

Author: var-const

firestore/integration_test_internal/src/bundle_test.cc

@@ -94,25 +94,6 @@ class BundleTest : public FirestoreIntegrationTest {
                                MapFieldValue{{"k", FieldValue::String("b")},
                                              {"bar", FieldValue::Integer(2)}}));
     }
-
-    {
-      Query limit = AwaitResult(db->NamedQuery(kLimitQueryName));
-      auto limit_snapshot = AwaitResult(limit.Get(Source::kCache));
-      EXPECT_THAT(
-          QuerySnapshotToValues(limit_snapshot),
-          testing::ElementsAre(MapFieldValue{{"k", FieldValue::String("b")},
-                                             {"bar", FieldValue::Integer(2)}}));
-    }
-
-    {
-      Query limit_to_last = AwaitResult(db->NamedQuery(kLimitToLastQueryName));
-      auto limit_to_last_snapshot =
-          AwaitResult(limit_to_last.Get(Source::kCache));
-      EXPECT_THAT(
-          QuerySnapshotToValues(limit_to_last_snapshot),
-          testing::ElementsAre(MapFieldValue{{"k", FieldValue::String("a")},
-                                             {"bar", FieldValue::Integer(1)}}));
-    }
   }
 };
 
@@ -259,21 +240,6 @@ TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
               testing::ElementsAre(
                   MapFieldValue{{"bar", FieldValue::String("newValueA")}},
                   MapFieldValue{{"bar", FieldValue::String("newValueB")}}));
-
-  {
-    Query limit = AwaitResult(db->NamedQuery(kLimitQueryName));
-    EXPECT_THAT(QuerySnapshotToValues(AwaitResult(limit.Get(Source::kCache))),
-                testing::ElementsAre(
-                    MapFieldValue{{"bar", FieldValue::String("newValueB")}}));
-  }
-
-  {
-    Query limit_to_last = AwaitResult(db->NamedQuery(kLimitToLastQueryName));
-    EXPECT_THAT(
-        QuerySnapshotToValues(AwaitResult(limit_to_last.Get(Source::kCache))),
-        testing::ElementsAre(
-            MapFieldValue{{"bar", FieldValue::String("newValueA")}}));
-  }
 }
 
 TEST_F(BundleTest, LoadedDocumentsShouldNotBeGarbageCollectedRightAway) {
@@ -316,28 +282,6 @@ TEST_F(BundleTest, LoadDocumentsFromOtherProjectsShouldFail) {
   VerifyErrorProgress(progresses[1]);
 }
 
-TEST_F(BundleTest, GetInvalidNamedQuery) {
-  Firestore* db = TestFirestore();
-  {
-    auto future = db->NamedQuery("DOES_NOT_EXIST");
-    Await(future);
-    EXPECT_EQ(future.status(), FutureStatus::kFutureStatusComplete);
-    EXPECT_EQ(future.error(), Error::kErrorNotFound);
-  }
-  {
-    auto future = db->NamedQuery("");
-    Await(future);
-    EXPECT_EQ(future.status(), FutureStatus::kFutureStatusComplete);
-    EXPECT_EQ(future.error(), Error::kErrorNotFound);
-  }
-  {
-    auto future = db->NamedQuery("\xc3\x28");
-    Await(future);
-    EXPECT_EQ(future.status(), FutureStatus::kFutureStatusComplete);
-    EXPECT_EQ(future.error(), Error::kErrorNotFound);
-  }
-}
-
 }  // namespace
 }  // namespace firestore
 }  // namespace firebase

firestore/src/ios/firestore_ios.h

@@ -100,7 +100,6 @@ class FirestoreInternal {
   Future<LoadBundleTaskProgress> LoadBundle(
       const std::string& bundle,
       std::function<void(const LoadBundleTaskProgress&)> progress_callback);
-  Future<Query> NamedQuery(const std::string& query_name);
 
   // Manages the ListenerRegistrationInternal objects.
   void RegisterListenerRegistration(ListenerRegistrationInternal* registration);