Skip to content

Fix absl leakage by using Firebase 8.2.0 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 29, 2021
Merged

Fix absl leakage by using Firebase 8.2.0 #491

merged 9 commits into from
Jun 29, 2021

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jun 24, 2021

No description provided.

@wu-hui wu-hui requested a review from var-const June 24, 2021 13:54
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@wu-hui wu-hui requested a review from jonsimantov June 24, 2021 13:54
@wu-hui wu-hui force-pushed the wuandy/FixAbslLeakage branch from d8bac3e to 0508efb Compare June 24, 2021 14:14
@wu-hui wu-hui added the tests-requested: quick Trigger a quick set of integration tests. label Jun 24, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 24, 2021
@github-actions
Copy link

github-actions bot commented Jun 24, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @wu-hui on commit 090eb4d
Last updated: Tue Jun 29 13:47 PDT 2021
View integration test log & download artifacts

Failures Configs
auth [TEST] [ERROR] [Windows] [openssl]
[TEST] [FAILURE] [Windows] [boringssl]
(2 failed tests)  TestLinkAnonymousUserWithEmailCredential
  TestUpdateEmailAndPassword

@wu-hui wu-hui added the tests-requested: quick Trigger a quick set of integration tests. label Jun 24, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2021
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 24, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2021
@wu-hui
Copy link
Contributor Author

wu-hui commented Jun 25, 2021

Added Firestore::NamedQuery that allows reading the queries used to build a Firestore Data Bundle.

Done.

@wu-hui
Merge branch 'main' into wuandy/FixAbslLeakage
6f862cb 
# Conflicts:
#	firestore/integration_test_internal/integration_test.xcodeproj/project.pbxproj
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 25, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 25, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 25, 2021
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 26, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 26, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 26, 2021
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 29, 2021
var-const
var-const approved these changes Jun 29, 2021
View reviewed changes
firestore/src/include/firebase/firestore.h
*
* @param query_name The name of the query to read from saved bundles.
*/
virtual Future<Query> NamedQuery(const std::string& query_name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about missing this earlier -- for all other functions in the public API that take string parameters, we have both a const std::string& overload and a const char* overload. Can you please file a bug to add the const char* overload here? (I'd rather keep it out of this PR)

@var-const var-const removed their assignment Jun 29, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 29, 2021
jonsimantov
jonsimantov approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vimanyu Make sure this is included in the next release

@wu-hui wu-hui merged commit 090eb4d into main Jun 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 29, 2021
jonsimantov pushed a commit that referenced this pull request Jul 1, 2021
@wu-hui @jonsimantov
Fix absl leakage by using Firebase 8.2.0 (#491)
63e56c2 
* Revert "Temporarily remove `NamedQuery` from the public API (#452)"

This reverts commit 8598f29

* Change to use absl-free interface.

* Change pod to 8.2.0

* Reformat

* Add release entry

* Reword

* Check in pbxproj changes
@jonsimantov jonsimantov deleted the wuandy/FixAbslLeakage branch July 12, 2021 22:49
@firebase firebase locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees

@jonsimantov jonsimantov

Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @var-const @jonsimantov